Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statement-distribution: Add tests for incoming acknowledgements #2498

Merged
merged 9 commits into from
Dec 5, 2023
Merged

statement-distribution: Add tests for incoming acknowledgements #2498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16d1287
statement-distribution: Add tests for incoming acknowledgements
mrcnski Nov 17, 2023
c60465e
Refactor a bit (can roll with this in a future PR if it looks good)
mrcnski Nov 26, 2023
d8d5bfa
Test receiving another valid ack
mrcnski Nov 26, 2023
457b82f
Refactor existing test to show how much nicer the new functions are
mrcnski Nov 26, 2023
b3b85b2
remove unused dep
mrcnski Dec 4, 2023
27fe1eb
Rename target_group -> other_group
mrcnski Dec 4, 2023
168e69b
change `assert_peer_reported` to macro
mrcnski Dec 4, 2023
37faf84
Fix macro
mrcnski Dec 4, 2023
2a6a710
Merge branch 'master' into mrcnski/statement-distribution-test-incomi…
mrcnski Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion polkadot/node/network/statement-distribution/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ sp-keystore = { path = "../../../../substrate/primitives/keystore" }
polkadot-node-subsystem = { path = "../../subsystem" }
polkadot-node-primitives = { path = "../../primitives" }
polkadot-node-subsystem-util = { path = "../../subsystem-util" }
polkadot-node-subsystem-types = { path = "../../subsystem-types" }
polkadot-node-network-protocol = { path = "../protocol" }
arrayvec = "0.7.4"
indexmap = "1.9.1"
Expand Down
2 changes: 1 addition & 1 deletion polkadot/node/network/statement-distribution/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
//! This is responsible for distributing signed statements about candidate
//! validity among validators.

// #![deny(unused_crate_dependencies)]
#![deny(unused_crate_dependencies)]
#![warn(missing_docs)]

use error::{log_error, FatalResult};
Expand Down
Loading