Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to enable v2 assignments #2444

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Nov 22, 2023

Scaffold everything, so that we can enable v2 assignments via a node feature bit, once all nodes have upgraded to the new protocol.

Implements: #628

Scaffold everything, so that we can enable v2 assignments via a node
feature bit, once all nodes have upgraded to the new protocol.

Implements: #628

Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to implement the suggestion in #2177 (comment) 👍🏻

polkadot/node/core/runtime-api/src/lib.rs Outdated Show resolved Hide resolved
polkadot/primitives/src/vstaging/mod.rs Outdated Show resolved Hide resolved
polkadot/node/core/runtime-api/src/lib.rs Outdated Show resolved Hide resolved
polkadot/primitives/src/vstaging/mod.rs Outdated Show resolved Hide resolved
polkadot/node/core/runtime-api/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/approval-voting/src/import.rs Outdated Show resolved Hide resolved
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Copy link
Contributor Author

alexggh commented Dec 5, 2023

@ordian @alindima @sandreim I think I addressed all of your concerns could you have another look, thank you!

@alexggh alexggh requested a review from ordian December 5, 2023 14:39
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexggh alexggh added R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Dec 8, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4661084

@alexggh alexggh enabled auto-merge (squash) December 8, 2023 15:58
@alexggh alexggh merged commit 84c932c into master Dec 11, 2023
91 of 115 checks passed
@alexggh alexggh deleted the alexaggh/feature_enablement branch December 11, 2023 10:49
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/raising-awareness-new-network-validation-protocol-version-v3-coming/5639/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants