Set clippy lints in workspace (requires rust 1.74) #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
requested review from
athei,
acatangiu,
sorpaas,
andresilva,
jsidorenko and
cheme
as code owners
|
@alvicsam let me know when CI happens to have rust updated and then this PR should go green. |
bkchr
approved these changes
Nov 17, 2023
koute
approved these changes
Nov 19, 2023
liamaharon
approved these changes
Nov 19, 2023
chevdor
approved these changes
Nov 20, 2023
lexnv
approved these changes
Nov 20, 2023
EgorPopelyaev
approved these changes
Nov 28, 2023
svyatonik
approved these changes
Dec 6, 2023
lexnv
approved these changes
Dec 7, 2023
|
@gilescope I updated rust in CI image to 1.74 |
sergejparity
approved these changes
Dec 7, 2023
ggwpez
approved these changes
Dec 7, 2023
…ec grep -Li "lints" {} \+`
Co-authored-by: Liam Aharon <[email protected]>
seadanda
reviewed
Dec 13, 2023
|
build green. time to merge? |
yes, I've just started discussion in CI channel about adding another check for all but lets merge and do follow up |
2 tasks
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
We currently use a bit of a hack in `.cargo/config` to make sure that clippy isn't too annoying by specifying the list of lints. There is now a stable way to define lints for a workspace. The only down side is that every crate seems to have to opt into this so there's a *few* files modified in this PR. Dependencies: - [x] PR that upgrades CI to use rust 1.74 is merged. --------- Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: Liam Aharon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use a bit of a hack in
.cargo/configto make sure that clippy isn't too annoying by specifying the list of lints.There is now a stable way to define lints for a workspace. The only down side is that every crate seems to have to opt into this so there's a few files modified in this PR.
Dependencies: