contracts migration: remove unnecessary panics #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
the
T1-FRAME
acatangiu
approved these changes
Oct 30, 2023
michalkucharczyk
approved these changes
Oct 30, 2023
liamaharon
commented
Oct 30, 2023
| @@ -107,7 +107,7 @@ check-rust-feature-propagation: | |||
| echo "---------- Building ${PACKAGE} runtime ----------" | |||
| time cargo build --release --locked -p "$PACKAGE" --features try-runtime | |||
|
|
|||
| echo "---------- Executing `on-runtime-upgrade` for ${NETWORK} ----------" | |||
| echo "---------- Executing on-runtime-upgrade for ${NETWORK} ----------" | |||
There was a problem hiding this comment.
otherwise causes error like [2023-10-30 08:59:54] /bin/bash: line 226: on-runtime-upgrade: command not found
alvicsam
approved these changes
Oct 30, 2023
sergejparity
approved these changes
Oct 30, 2023
liamaharon
deleted the
liam-contracts-migration-remove-unnesesarry-panics
branch
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Runtime migration CI is currently failing (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/4122083) for the contracts testnet due to unnecessary panicing in a `pre_upgrade` hook. Soon idempotency will be enforced paritytech/try-runtime-cli#42, in the mean time we need to manually fix these issues as they arise. --- also removes backticks from the string in `echo`, which caused a 'command not found' error in ci output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime migration CI is currently failing (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/4122083) for the contracts testnet due to unnecessary panicing in a
pre_upgradehook.Soon idempotency will be enforced paritytech/try-runtime-cli#42, in the mean time we need to manually fix these issues as they arise.
also removes backticks from the string in
echo, which caused a 'command not found' error in ci output