Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statement-distribution: validator disabling #1841

Merged
merged 13 commits into from
Jan 10, 2024
Merged

statement-distribution: validator disabling #1841

merged 13 commits into from
Jan 10, 2024

Conversation

ordian
Copy link
Member

@ordian ordian commented Oct 10, 2023 •
edited
Loading

Closes #1591.

The purpose of this PR is filter out backing statements from the network signed by disabled validators. This is just an optimization, since we will do filtering in the runtime in #1863 to avoid nodes to filter garbage out at block production time.

  • Ensure it's ok to fiddle with the mask of manifests
  • Write more unit tests
  • Test locally
  • simple zombienet test
  • PRDoc

@ordian ordian added T0-node This PR/Issue is related to the topic “node”. T9-parachains_protocol labels Oct 10, 2023
@ordian ordian changed the title stament-distribution: validator disabling statement-distribution: validator disabling Oct 10, 2023
@ordian ordian force-pushed the ao-disabling-statement-distribution branch from e333fa8 to 9f6736d Compare October 12, 2023 08:53
@ordian ordian changed the base branch from tsv-disabling-backing to tsv-disabling October 16, 2023 11:38
@ordian ordian changed the base branch from tsv-disabling to tsv-disabling-backing October 16, 2023 11:38
Base automatically changed from tsv-disabling-backing to tsv-disabling October 20, 2023 13:13
@tdimitrov tdimitrov mentioned this pull request Oct 20, 2023
Closed
4 tasks
@ordian ordian mentioned this pull request Oct 20, 2023
Closed
@ordian ordian marked this pull request as ready for review October 26, 2023 14:01
@ordian ordian requested a review from a team as a code owner October 26, 2023 15:52
@mrcnski mrcnski self-requested a review October 30, 2023 16:04
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 3, 2023 13:20
@tdimitrov
Copy link
Contributor

I'm not familiar with statement-distribution and I can't provide any sensible feedback, but changes look sane to me.

@tdimitrov tdimitrov mentioned this pull request Nov 8, 2023
Open
18 tasks
@eskimor
Copy link
Member

eskimor commented Nov 8, 2023

Fixes #1591

eskimor
eskimor reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we properly disabling both in grid and in cluster distribution?

@ordian ordian requested review from a team November 8, 2023 12:49
@ordian ordian requested a review from a team November 8, 2023 12:49
@ordian ordian requested review from koute and a team as code owners November 8, 2023 12:49
@ordian ordian removed the request for review from a team November 8, 2023 12:52
@ordian ordian force-pushed the ao-disabling-statement-distribution branch from c3bb3f4 to 551219b Compare December 20, 2023 15:20
@ordian ordian changed the base branch from tsv-disabling to ao-backport-backing-disabling December 20, 2023 15:20
@ordian ordian removed request for a team, sorpaas, jsidorenko and cheme December 20, 2023 15:20
@paritytech-review-bot paritytech-review-bot bot requested a review from a team December 20, 2023 15:20
@ordian ordian removed the request for review from a team December 20, 2023 17:10
tdimitrov
tdimitrov approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@tdimitrov tdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a disclaimer: this is my first encounter with statement-distribution 😕

Base automatically changed from ao-backport-backing-disabling to master January 8, 2024 19:58
tdimitrov added a commit that referenced this pull request Jan 8, 2024
@ordian @tdimitrov
backport to master: Handling of disabled validators in backing subsys…
a02b534 
…tem (#1259) (#2764)

#1259 was merged into a feature branch, but we've decided to merge
node-side changes for disabling straight into master.
This is a dependency of #1841 and #2637.

---------

Co-authored-by: Tsvetomir Dimitrov <[email protected]>
@ordian ordian enabled auto-merge (squash) January 9, 2024 11:22
@ordian ordian merged commit a419532 into master Jan 10, 2024
122 checks passed
@ordian ordian deleted the ao-disabling-statement-distribution branch January 10, 2024 09:32
@kamilsa kamilsa mentioned this pull request Jan 17, 2024
Open
5 tasks
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphmeier rphmeier rphmeier left review comments

@mrcnski mrcnski mrcnski approved these changes

@eskimor eskimor eskimor left review comments

@pepoviola pepoviola pepoviola left review comments

@Overkillus Overkillus Overkillus approved these changes

@tdimitrov tdimitrov tdimitrov approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator disabling in statement-distribution subsystem
8 participants
@ordian @tdimitrov @eskimor @pepoviola @mrcnski @rphmeier @Overkillus @the-right-joyce