Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump ci image to rust 1.73.0 #1830

Merged
merged 7 commits into from
Oct 11, 2023
Merged

ci: bump ci image to rust 1.73.0 #1830

merged 7 commits into from
Oct 11, 2023

Conversation

altaua
Copy link
Contributor

@altaua altaua commented Oct 9, 2023

No description provided.

@altaua altaua added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes labels Oct 9, 2023
@altaua altaua self-assigned this Oct 9, 2023
@altaua altaua force-pushed the mira/rust-1.73 branch 3 times, most recently from 16a5b68 to 3591975 Compare October 10, 2023 20:35
@paritytech paritytech deleted a comment from command-bot bot Oct 10, 2023
@paritytech paritytech deleted a comment from command-bot bot Oct 10, 2023
@altaua
Copy link
Contributor Author

altaua commented Oct 10, 2023

bot update-ui -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.73.0-2023-05-23-v20231009

@command-bot
Copy link

command-bot bot commented Oct 10, 2023

@altaua https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-d64c5649-a04f-4694-b994-73d77eabec62 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 10, 2023

@altaua Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179/artifacts/download.

@altaua
Copy link
Contributor Author

altaua commented Oct 10, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 10, 2023

@altaua https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 22-7c29411d-8ff3-48bf-b8e7-36fb80c068ac to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 10, 2023

@altaua Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467/artifacts/download.

@altaua altaua marked this pull request as ready for review October 10, 2023 22:39
@altaua altaua requested a review from athei as a code owner October 10, 2023 22:39
@altaua altaua requested a review from a team October 10, 2023 22:40
@altaua altaua requested a review from a team October 10, 2023 22:40
@altaua altaua requested review from koute and a team as code owners October 10, 2023 22:40
@paritytech-ci paritytech-ci requested a review from a team October 10, 2023 22:41
@@ -1423,7 +1423,6 @@ impl NetworkBehaviour for Notifications {
let delay_id = self.next_delay_id;
self.next_delay_id.0 += 1;
let delay = futures_timer::Delay::new(ban_duration);
let peer_id = peer_id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why these were here before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used to be let peer_id = *peer_id; until this commit, which just removed the * and left the remaining no-op line around.

.cargo/config.toml Outdated Show resolved Hide resolved
@altaua altaua force-pushed the mira/rust-1.73 branch 2 times, most recently from 023a9e8 to 8333105 Compare October 11, 2023 15:50
@ggwpez
Copy link
Member

ggwpez commented Oct 11, 2023

Can you also check if its worth to update the Rust version that the bot fmt uses please?
Currently we are on nightly-2023-05-16.

@altaua
Copy link
Contributor Author

altaua commented Oct 11, 2023

Can you also check if its worth to update the Rust version that the bot fmt uses please? Currently we are on nightly-2023-05-16.

yeah that's on the todo list too, nightly bumps are always a huge hassle though

@altaua altaua requested a review from a team October 11, 2023 16:58
@altaua altaua merged commit 447e753 into master Oct 11, 2023
9 of 10 checks passed
@altaua altaua deleted the mira/rust-1.73 branch October 11, 2023 17:50
ordian added a commit that referenced this pull request Oct 12, 2023
* master: (33 commits)
  ci: set CI_IMAGE back to (now updated) .ci-unified (#1854)
  ci: bump ci image to rust 1.73.0 (#1830)
  Refactor Identity to benchmark v2 (#1838)
  PVF worker: bump landlock, update ABI docs (#1850)
  Xcm emulator nits (#1649)
  Fixes path issue in derive-impl (#1823)
  upgrade to macro_magic 0.4.3 (#1832)
  Use safe math when pruning statuses (#1835)
  remote-ext: fix state download stall on slow connections and reduce memory usage (#1295)
  Update testnet bootnode dns name (#1712)
  [FRAME] Warn on unchecked weight witness (#1818)
  [xcm] Use `Weight::MAX` for `reserve_asset_deposited`, `receive_teleported_asset` benchmarks (#1726)
  Update bridges subtree (#1803)
  Check for parent of first ready block being on chain (#1812)
  Make CheckNonce refuse transactions signed by accounts with no providers (#1578)
  Fix Asset Hub collator crashing when starting from genesis (#1788)
  Mixnet integration (#1346)
  [xcm-emulator] Decouple the `AccountId` type from `AccountId32` (#1458)
  Treasury spends various asset kinds (#1333)
  chore: bump zombienter version (#1806)
  ...
acatangiu pushed a commit to acatangiu/polkadot-sdk that referenced this pull request Oct 31, 2023
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Co-authored-by: command-bot <>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
bkchr pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants