Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix simple analytics injection script #1501

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

liamaharon
Copy link
Contributor

When process_file is run by xargs, it is executed inside a new shell without access to variables defined outside of its scope.

This resulted in script_content being an empty string.

By exporting script_content prior to running xargs it is available inside the new shells.

@liamaharon liamaharon added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Sep 12, 2023
@liamaharon liamaharon requested a review from a team as a code owner September 12, 2023 02:07
@paritytech-ci paritytech-ci requested a review from a team September 12, 2023 02:08
@paritytech-ci paritytech-ci requested a review from a team September 12, 2023 05:38
@liamaharon liamaharon enabled auto-merge (squash) September 12, 2023 05:56
@liamaharon liamaharon merged commit 77c867b into master Sep 12, 2023
13 checks passed
@liamaharon liamaharon deleted the la-fix-sa-injection branch September 12, 2023 06:13
@chevdor chevdor added the R0-silent Changes should not be mentioned in any release notes label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants