Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor: Remove LegacyInstanceReuse strategy #1486

Merged
merged 19 commits into from
Sep 18, 2023
Merged

Executor: Remove LegacyInstanceReuse strategy #1486

merged 19 commits into from
Sep 18, 2023

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Sep 11, 2023 •
edited
Loading

It seems the old strategy have been depracted more than one year.
So maybe it's time to clean up old strategy for wasm executor.

polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr

bkchr
bkchr reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, otherwise looks good.

substrate/client/executor/src/integration_tests/linux.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from koute September 11, 2023 09:02
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Sep 11, 2023
@yjhmelody
Copy link
Contributor Author

yjhmelody commented Sep 12, 2023 •
edited
Loading

@koute Is test memory_consumption_compiled still useful? Seem could not work for other strategies.
Not easy for me to fix it.

@yjhmelody
Copy link
Contributor Author

Hi @bkchr @koute I have no idea to solve memory_consumption_compiled test. Seems only work fine for old strategy.
Should I just remove this test?

@koute
Copy link
Contributor

koute commented Sep 13, 2023

Hi @bkchr @koute I have no idea to solve memory_consumption_compiled test. Seems only work fine for old strategy. Should I just remove this test?

Yes. Nuke it. We don't have to test this as in non-legacy strategies we don't do our own memory clearing, and wasmtime itself guarantees this.

@yjhmelody
Copy link
Contributor Author

@koute anything need to be done？

@bkchr bkchr changed the title Cleanup legacy strategy executor Executor: Remove LegacyInstanceReuse strategy Sep 17, 2023
koute
koute approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@koute koute merged commit e389988 into paritytech:master Sep 18, 2023
7 checks passed
@yjhmelody yjhmelody deleted the cleanup-legacy-executor branch September 30, 2023 04:05
@yjhmelody
Copy link
Contributor Author

@bkchr Can I get a tip by bot? If not, I will issue a small tipper at openGov for myself.

@yjhmelody yjhmelody mentioned this pull request Oct 2, 2023
Merged
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
@alstjd0921 alstjd0921 mentioned this pull request Dec 12, 2023
Merged
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@yjhmelody @bkchr @koute
Executor: Remove LegacyInstanceReuse strategy (paritytech#1486)
381bcdc 
It seems the old strategy have been depracted more than one year. 
So maybe it's time to clean up old strategy for wasm executor.


---
polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Koute <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@koute koute koute approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjhmelody @koute @bkchr