bump parity-scale-codec to 3.6.8

[pgherveou]

Bump parity-scale-codec to 3.6.8.
Specifically I want to add the fixes to MaxEncodedLen added by paritytech/parity-scale-codec#510

Note: I updated with cargo upgrade --pinned allow -p [email protected] --offline forcing all versions to 3.6.8
if this undesired (we can update all versions to the compatible version without --pinned allow)

[pgherveou]

Hum looks like it's breaking the build, will look into it, later today...

[pgherveou]

I think that one issue here, is that we have updated parity-scale-codec so that

#[codec(compact)]
foo: u64,

compiles to

<::codec::Compact<u64> as ::codec::MaxEncodedLen>::max_encoded_len()

instead of

u64::max_encoded_len()

This is all fine but this cause some compilation errors when this field is generic

#[codec(compact)]
deposit: BalanceOf<T>,

// 53 |         pub deposit: BalanceOf<T, OldCurrency>,
//    |                      ^^^^^^^^^ the trait `parity_scale_codec::MaxEncodedLen` is not implemented for `parity_scale_codec::Compact<<OldCurrency as Currency<<T as frame_system::Config>::AccountId>>::Balance>`

[bkchr]

@pgherveou I know you have pr to fix this, but did you already yanked this version?

[pgherveou]

Yes i did

[ggwpez]

Hm CI reports overflow evaluating the requirement parity_scale_codec::Compact<_>: parity_scale_codec::MaxEncodedLen.

[pgherveou]

evaluating

testing with this patch
df08bf0

paritytech/parity-scale-codec#516

also one more question, is that safe to update all crates here, I see that some versions are quite outdated (v3.0.0) is that safe to update ?

[ggwpez]

also one more question, is that safe to update all crates here, I see that some versions are quite outdated (v3.0.0) is that safe to update ?

Its semver, so they all use the latest version. But yes to ahead and force them to the latest - makes it easier to read.

[pgherveou]

Need to push 3.6.8 now and try again will do that later

[ggwpez]

Need to push 3.6.8 now and try again will do that later

Okay thanks. The UI tests wont work with a diener patch, since they snapshot the import paths.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3638384

[pgherveou]

damned one more, I thought I caught all the tests previously, will yank and try again

[pgherveou]

closing for now as the proposed version breaks semver, this patch can wait for 4.x