-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure cumulus/bridges
is ignored by formatter and run it
#1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
T0-node
This PR/Issue is related to the topic “node”.
labels
Sep 3, 2023
gavofyork
changed the title
Ensure cumulus/bridges is ignored by formatter and run it
Ensure Sep 3, 2023
cumulus/bridges
is ignored by formatter and run it
ggwpez
approved these changes
Sep 3, 2023
ggwpez
reviewed
Sep 3, 2023
@@ -19,9 +19,9 @@ trailing_comma = "Vertical" | |||
trailing_semicolon = false | |||
use_field_init_shorthand = true | |||
ignore = [ | |||
"bridges", | |||
"cumulus/bridges", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acatangiu this should be remove, or?
The current formatting files was merged as part of the monorepo import.
bkchr
approved these changes
Sep 3, 2023
ordian
added a commit
that referenced
this pull request
Sep 7, 2023
* master: (25 commits) Markdown linter (#1309) Update `fmt` file and some authors (#1379) Bump the known_good_semver group with 1 update (#1375) Bump proc-macro-warning from 0.4.1 to 0.4.2 (#1376) feat: add futures api to `TransactionPool` (#1348) Ensure cumulus/bridges is ignored by formatter and run it (#1369) substrate: chain-spec paths corrected in zombienet tests (#1362) contracts: Update to wasmi 0.31 (#1350) [improve docs]: Template pallet (#1280) [xcm-emulator] Unignore cumulus integration tests (#1247) Fix wrong ref counting (#1358) Use cached session index to obtain executor params (#1190) fix typos (#1339) Use bandersnatch-vrfs with locked dependencies ref (#1342) Bump bs58 from 0.4.0 to 0.5.0 (#1293) Contracts: `seal0::balance` should return the free balance (#1254) Logs: add extra debug log for negative rep changes (#1205) Added short-benchmarks for cumulus (#1183) [xcm-emulator] Improve hygiene and clean up (#1301) Bump the known_good_semver group with 1 update (#1347) ...
Ank4n
pushed a commit
that referenced
this pull request
Sep 8, 2023
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
T0-node
This PR/Issue is related to the topic “node”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor fix to
.rustfmt.toml
which had the incorrect path for bridges together with the few changes resulting from running it.