-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old UI test #1289
Remove old UI test #1289
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@@ -312,9 +312,8 @@ test-frame-support: | |||
# Ensure we run the UI tests. | |||
RUN_UI_TESTS: 1 | |||
script: | |||
- time cargo test --locked -p frame-support-test --features=frame-feature-testing,no-metadata-docs,try-runtime,experimental --manifest-path ./substrate/frame/support/test/Cargo.toml | |||
- time cargo test --locked -p frame-support-test --features=frame-feature-testing,frame-feature-testing-2,no-metadata-docs,try-runtime,experimental --manifest-path ./substrate/frame/support/test/Cargo.toml | |||
- SUBSTRATE_TEST_TIMEOUT=1 time cargo test -p substrate-test-utils --release --locked -- --ignored timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it was running this test:
async fn timeout() { |
Either way, it does not belong into a FRAME CI job.
I wonder if we still need this substrate_test_utils::test
macro or can use tokio::test
instead.
// Deny all warnings since we emit warnings as part of a Runtime's UI. | ||
std::env::set_var("RUSTFLAGS", "--deny warnings"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already do this in the CI job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but then the result is different from running it locally.
Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Liam Aharon <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Liam Aharon <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Liam Aharon <[email protected]>
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (paritytech#1289)
…ery/confirmation transactions (#1289)
Default bound for the Genesis builder got removed here #1221, therefore deleting the UI test.
Also cleaning up the UI CI job. Seems to have some legacy dust - i could not determine why this
substrate-test-utils
was in there 🤔