Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polkadot zombienet tests #1276

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Fix polkadot zombienet tests #1276

merged 8 commits into from
Aug 30, 2023

Conversation

sandreim
Copy link
Contributor

Adds back some tests which have been missed during the migration to monorepo .

@sandreim sandreim added R0-silent Changes should not be mentioned in any release notes T8-parachains_engineering labels Aug 29, 2023
@paritytech-ci paritytech-ci requested review from a team August 29, 2023 16:01
@paritytech-ci paritytech-ci requested a review from a team August 30, 2023 11:02
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sandreim
Copy link
Contributor Author

the tests seem to be failing but there is nothing in the logs showing why - https://grafana.teleport.parity.io/goto/wsd83nkSR?orgId=1 . CC @pepoviola would be great to take a look

@pepoviola
Copy link
Contributor

the tests seem to be failing but there is nothing in the logs showing why - https://grafana.teleport.parity.io/goto/wsd83nkSR?orgId=1 . CC @pepoviola would be great to take a look

I will check asap 👍

Signed-off-by: Andrei Sandu <[email protected]>
@pepoviola
Copy link
Contributor

@sandreim test are fixed now, only zombienet-polkadot-functional-0005-parachains-disputes-past-session is failing (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3498474) this was also failing in the past.

@ordian
Copy link
Member

ordian commented Aug 30, 2023

❌ honest-validator: parachain 1000 block height is at least 1 within 300 seconds (300006ms)

Looks like collator didn't produce any blocks before the actual test logic began. Where can I find the collator logs? I've been running the test locally and it fails not so often and with #1220 it should be more robust. But this is test should not be required for merge for now.

@sandreim
Copy link
Contributor Author

@sandreim test are fixed now, only zombienet-polkadot-functional-0005-parachains-disputes-past-session is failing (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3498474) this was also failing in the past.

Yeah, it's tracked here: #578

@sandreim
Copy link
Contributor Author

❌ honest-validator: parachain 1000 block height is at least 1 within 300 seconds (300006ms)

Looks like collator didn't produce any blocks before the actual test logic began. Where can I find the collator logs? I've been running the test locally and it fails not so often and with #1220 it should be more robust. But this is test should not be required for merge for now.

https://grafana.teleport.parity.io/goto/jLgVV4zSR?orgId=1

@pepoviola
Copy link
Contributor

❌ honest-validator: parachain 1000 block height is at least 1 within 300 seconds (300006ms)

Looks like collator didn't produce any blocks before the actual test logic began. Where can I find the collator logs? I've been running the test locally and it fails not so often and with #1220 it should be more robust. But this is test should not be required for merge for now.

This are the full logs of the collator https://grafana.teleport.parity.io/goto/GFvSVVzIR?orgId=1, let me know if I can help you to check this.
Thx!

@ordian
Copy link
Member

ordian commented Aug 30, 2023

2023-08-30 14:03:48.076 ERROR tokio-runtime-worker cumulus-collator: [Parachain] Could not decode the head data. error=Error { cause: Some(Error { cause: None, desc: "Not enough data to fill buffer" }), desc: "Could not decode Header::parent_hash" }

Probably same issue as reported in #578, though it has nothing to do with garbage candidate since the malus is paused at the beginning. Maybe an outdated image for collator? I couldn't repro this when building from master.

@sandreim
Copy link
Contributor Author

bot merge

@command-bot
Copy link

command-bot bot commented Aug 30, 2023

@sandreim Unknown command "merge". Refer to help docs and/or source code.

@sandreim sandreim merged commit b46f07f into master Aug 30, 2023
4 checks passed
@sandreim sandreim deleted the sandreim/zombinet_tests_fix branch August 30, 2023 14:58
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* fix tests

Signed-off-by: Andrei Sandu <[email protected]>

* ZOMBIENET_INTEGRATION_TEST_SECONDARY_IMAGE

Signed-off-by: Andrei Sandu <[email protected]>

* deleted by mistake

Signed-off-by: Andrei Sandu <[email protected]>

* remove LOCAL_DIR override

Signed-off-by: Andrei Sandu <[email protected]>

* Fix secondary image

Signed-off-by: Andrei Sandu <[email protected]>

* fix get BUILD_RELEASE_VERSION in pipeline

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: Javier Viola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants