-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix polkadot zombienet tests #1276
Conversation
Signed-off-by: Andrei Sandu <[email protected]>
…reim/zombinet_tests_fix
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
…reim/zombinet_tests_fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
the tests seem to be failing but there is nothing in the logs showing why - https://grafana.teleport.parity.io/goto/wsd83nkSR?orgId=1 . CC @pepoviola would be great to take a look |
I will check asap 👍 |
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim test are fixed now, only |
Looks like collator didn't produce any blocks before the actual test logic began. Where can I find the collator logs? I've been running the test locally and it fails not so often and with #1220 it should be more robust. But this is test should not be required for merge for now. |
Yeah, it's tracked here: #578 |
|
This are the full logs of the collator https://grafana.teleport.parity.io/goto/GFvSVVzIR?orgId=1, let me know if I can help you to check this. |
Probably same issue as reported in #578, though it has nothing to do with garbage candidate since the malus is paused at the beginning. Maybe an outdated image for collator? I couldn't repro this when building from master. |
bot merge |
@sandreim Unknown command "merge". Refer to help docs and/or source code. |
* fix tests Signed-off-by: Andrei Sandu <[email protected]> * ZOMBIENET_INTEGRATION_TEST_SECONDARY_IMAGE Signed-off-by: Andrei Sandu <[email protected]> * deleted by mistake Signed-off-by: Andrei Sandu <[email protected]> * remove LOCAL_DIR override Signed-off-by: Andrei Sandu <[email protected]> * Fix secondary image Signed-off-by: Andrei Sandu <[email protected]> * fix get BUILD_RELEASE_VERSION in pipeline --------- Signed-off-by: Andrei Sandu <[email protected]> Co-authored-by: Javier Viola <[email protected]>
Adds back some tests which have been missed during the migration to monorepo .