Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payees lazy migration to PayoutDestination, Split variant for payouts, remove Controller #1196

Closed
wants to merge 53 commits into from
Closed

Payees lazy migration to PayoutDestination, Split variant for payouts, remove Controller #1196

wants to merge 53 commits into from

Conversation

rossbulat
Copy link

Tracking issue: #1195

This PR is part 1 of a lazy migration to update reward destinations, which removes Controller, refactors RewardDestination into a new PayoutDestination enum, and adds an additional Split enum for the ability to compound a part of rewards and have the rest as free balance.

  • Create PayoutDestination with new variants and introduce Payees storage item to replace Payee.
  • set_payee removes Payee (RewardDestination) and inserts to Payees (PayoutDestination)
  • Introduce update_payee call to lazily migrate from Payee to Payees storage item.
  • Implement Split logic on payout_stakers with getter that migrates Payee to new Payees storage.
  • Review staking benchmarks and ensure they are worst case scenario (Split, existing Payee).
  • Add tests again for fee-less update_payee.
  • Add tests for get_payout_destination, ensure Payees is populated.

@rossbulat rossbulat added I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet. labels Aug 28, 2023
@paritytech-ci paritytech-ci requested review from a team August 28, 2023 02:31
@rossbulat rossbulat mentioned this pull request Aug 28, 2023
Open
@rossbulat rossbulat requested review from a team September 14, 2023 03:28
@paritytech paritytech deleted a comment from command-bot bot Sep 14, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3959041

@rossbulat
Copy link
Author

rossbulat commented Oct 25, 2023 •
edited
Loading

Just a note for AppSec, this PR has broken due to a ledger refactor & needs to be fixed. It'll involve rebuilding the PR from the latest master I imagine. I will take a stab this week.

@rossbulat rossbulat mentioned this pull request Oct 31, 2023
Closed
7 tasks
@rossbulat rossbulat mentioned this pull request Nov 21, 2023
Merged
6 tasks
@rossbulat rossbulat mentioned this pull request Feb 5, 2024
Open
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
3b46cf3 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
0210104 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
7717c69 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
bc8ca03 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
e1c7df6 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
eb1902a 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
ff8274d 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
3549b39 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
7946be9 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
ff9df26 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
5052a9c 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Fix transactions mortality (paritytech#1196)
201336e 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Fix transactions mortality (#1196)
cc6320c 
* added lost stall timeout fix

* use best_block.parent() to start mortal tx era

* fmt

* Revert "revert messages transactions mortality"

This reverts commit 77776357dafdfa80dcb3ec307d76fcfd0d5195bb.
This was referenced Jun 5, 2024
Closed
Closed
@bkchr
Copy link
Member

bkchr commented Jul 17, 2024

@Ank4n why was this never merged? Should we now close this pr?

@Ank4n
Copy link
Contributor

Ank4n commented Aug 4, 2024

@Ank4n why was this never merged? Should we now close this pr?

This is probably blocked by #3706 that is not yet executed.
@rossbulat @gpestana Is this PR still valid?

@rossbulat
Copy link
Author

There was a lack of interest in reviewing and finalising this so it never got past the finish line.

It can be closed and reimplemented as the codebase has changed and I don't have org access to manage this PR anymore.

@rossbulat rossbulat closed this Aug 4, 2024
@bkchr bkchr deleted the rb-payout-destination branch August 12, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma left review comments

@gpestana gpestana gpestana approved these changes

@Ank4n Ank4n Ank4n approved these changes

Assignees
No one assigned
Labels
I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Security Audit (PRs) - Parity Security
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rossbulat @paritytech-cicd-pr @bkchr @Ank4n @gpestana @kianenigma @uzeyirdestan