Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract block announce validation from ChainSync #1170

Merged
merged 35 commits into from
Sep 4, 2023
Merged

Extract block announce validation from ChainSync #1170

merged 35 commits into from
Sep 4, 2023

Commits on Aug 25, 2023

  1. Extract block announce validation/polling from ChainSync

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c8c1cf6 View commit details
    Browse the repository at this point in the history

  2. Get rid of push_block_announce_validation_inner

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    0046f35 View commit details
    Browse the repository at this point in the history

  3. Extend ChainSync trait with on_validated_block_announce

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d41acb3 View commit details
    Browse the repository at this point in the history

  4. minor: fix visibilities

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    72d6d69 View commit details
    Browse the repository at this point in the history

  5. Fix: poll ChainSync from SyncingEngine

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c52f076 View commit details
    Browse the repository at this point in the history

  6. minor: spelling

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    36a002e View commit details
    Browse the repository at this point in the history

  7. Unify PeerId variable names as peer_id

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e307f9a View commit details
    Browse the repository at this point in the history

  8. Assert when deallocating block announce validation slot counter

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2186e0f View commit details
    Browse the repository at this point in the history

  9. Extract block announce validation from SyncingEngine

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c6461e0 View commit details
    Browse the repository at this point in the history

  10. Simplify naming in BlockAnnounceValidator

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5b6e10a View commit details
    Browse the repository at this point in the history

  11. Implement Stream trait for BlockAnnounceValidator

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a67c9c8 View commit details
    Browse the repository at this point in the history

  12. minor: simplify code a little

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    32e95be View commit details
    Browse the repository at this point in the history

  13. WIP: wake-up task if new validation is added to BlockAnnounceValidator

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c925e77 View commit details
    Browse the repository at this point in the history

  14. Wake up task when new validation is added to BlockAnnounceValidator

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    51ff231 View commit details
    Browse the repository at this point in the history

  15. Get rid of PreValidateBlockAnnounce

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    936cf4f View commit details
    Browse the repository at this point in the history

  16. Remove now unneeded polling after pushing block announce validation

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1448225 View commit details
    Browse the repository at this point in the history

  17. Add tests for validation slot allocation

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    03597be View commit details
    Browse the repository at this point in the history

  18. minor: make rutdoc happy

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    aa48154 View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review 

    Co-authored-by: Aaro Altonen <[email protected]>
Co-authored-by: Anton <[email protected]>
    @dmitry-markin @altonen @melekes
    3 people committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ec6b028 View commit details
    Browse the repository at this point in the history

  20. Use futures::ready! to simplify polling

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d242f5f View commit details
    Browse the repository at this point in the history

  21. Prepare BloackAnnounceValidator for pushing block announcements fro… 

    …m somewhere else
    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e42954f View commit details
    Browse the repository at this point in the history

  22. minor: comment

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    859237b View commit details
    Browse the repository at this point in the history

  23. minor: rustfmt

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bf99c1c View commit details
    Browse the repository at this point in the history

  24. Get rid of a channel in FuturesStream

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    14b76f1 View commit details
    Browse the repository at this point in the history

  25. Merge remote-tracking branch 'origin/master' into dm-extract-block-an… 

    …nounce-validation-from-chainsync
    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d728fe0 View commit details
    Browse the repository at this point in the history

  26. minor: docs

    @dmitry-markin
    dmitry-markin committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c3f9ab6 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Merge remote-tracking branch 'origin/master' into dm-extract-block-an… 

    …nounce-validation-from-chainsync
    @dmitry-markin
    dmitry-markin committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    096c0e0 View commit details
    Browse the repository at this point in the history

  2. Apply code review suggestions

    @dmitry-markin
    dmitry-markin committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ca546cd View commit details
    Browse the repository at this point in the history

  3. minor: replace spaces with tabs

    @dmitry-markin
    dmitry-markin committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    55046c5 View commit details
    Browse the repository at this point in the history

  4. minor: comment

    @dmitry-markin
    dmitry-markin committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5610da0 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into dm-extract-block-an… 

    …nounce-validation-from-chainsync
    @dmitry-markin
    dmitry-markin committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    43d8e56 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Fix possible underflow by using saturating_sub

    @dmitry-markin
    dmitry-markin committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c9797a5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into dm-extract-block-an… 

    …nounce-validation-from-chainsync
    @dmitry-markin
    dmitry-markin committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c8340e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Merge remote-tracking branch 'origin/master' into dm-extract-block-an… 

    …nounce-validation-from-chainsync
    @dmitry-markin
    dmitry-markin committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    04c1348 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Merge remote-tracking branch 'origin/master' into dm-extract-block-an… 

    …nounce-validation-from-chainsync
    @dmitry-markin
    dmitry-markin committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    d629420 View commit details
    Browse the repository at this point in the history