Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Macro for Generating MultiLocations with Arbitrary Number of Junctions #974

Open
shawntabrizi opened this issue Mar 29, 2021 · 3 comments
Open

Create a Macro for Generating MultiLocations with Arbitrary Number of Junctions #974

shawntabrizi opened this issue Mar 29, 2021 · 3 comments

Comments

@shawntabrizi
Copy link
Member

Right now there is a lot of duplicate / pattern code in the MultiLocation definition to support junctions of up to length 8.

See: paritytech/polkadot#2662

This could be made into a macro to make such code generation for any number of junctions easy and compact.
@shawntabrizi shawntabrizi mentioned this issue Mar 29, 2021
Merged
@kianenigma
Copy link
Contributor

kianenigma commented Apr 29, 2021 •
edited
Loading

This is related to:

MultiLocation should support arbitrary size through having a Vec backed item. This will need a custom codec impl but we can remove overflow error handling.

from: paritytech/polkadot#2841

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. and removed C3-medium labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@yrong @vgeddes
SNO-632: Submit outbound message with priority control (paritytech#949)
c05de23 
* Submit outbound message without MessageQueue

* Priority control

* Update priority

* Update cumulus

* Reserve space for high priority messages

* Fix compile error & More refactor

* Improve processing high priority messages

* Some polish

* Add priority back

* Improve comments

* Rename priority to normal

* Refactor submit logic

* Refactor process message

* Add type HighPriorityCommands

* Fix clippy

* Rename priority with BridgeHub

* Update parachain/primitives/core/src/outbound.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Update parachain/pallets/outbound-queue/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Update parachain/pallets/outbound-queue/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Revamp with ExportOrigin

* Fix format

* Some polish

* Check weight before processing message (paritytech#974)

* update cumulus submodule

* Improve comments

* update cumulus

* Update cumulus

---------

Co-authored-by: Vincent Geddes <[email protected]>
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@yrong @vgeddes
Delivery fee should cover cost of local processing (paritytech#975)
187c3ff 
* Submit outbound message without MessageQueue

* Priority control

* Update priority

* Update cumulus

* Reserve space for high priority messages

* Fix compile error & More refactor

* Improve processing high priority messages

* Some polish

* Add priority back

* Improve comments

* Rename priority to normal

* Refactor submit logic

* Refactor process message

* Add type HighPriorityCommands

* Fix clippy

* Rename priority with BridgeHub

* Update parachain/primitives/core/src/outbound.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Update parachain/pallets/outbound-queue/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Update parachain/pallets/outbound-queue/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Revamp with ExportOrigin

* Fix format

* Some polish

* Check weight before processing message (paritytech#974)

* update cumulus submodule

* Include base_fee

* Redeem vouchers for delivery fee

* Estimate fee upon commit_one_message

* Balance type as u128

* Improve comments

* Runtime api for estimate_fee

* Remove all voucher&redeem stuff

* Fix for clippy

* Benchmark for do_submit_message

* Add delivery_fee

* Improve fee test

* Remove benchmark for submit

* Add comments

* Rename to calculate_fee

* Comments

* Add method for total fee

* Short name

* Rename to commit_messages

* Use Balance generic for the api

* Update parachain/pallets/outbound-queue/runtime-api/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Rename generic Runtime to T

* Remove fee from OutboundQueueTicket

* Rename to fees

---------

Co-authored-by: Vincent Geddes <[email protected]>
Co-authored-by: Vincent Geddes <[email protected]>
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@koushiro
Use workspace inheritance for dependencies (paritytech#974)
a756c0a 
* use workspace inheritance for package info

* primitives: use workspace inheritance for dependencies

* frame: use workspace inheritance for dependencies

* primitives: adjust codec dep inheritance

* client: use workspace inheritance for dependencies

* frame: use workspace inheritance for dev-dependencies

* adjust toml format

* template: use workspace inheritance for dependencies

* rename codec ==> scale-codec for better format
@ggwpez
Copy link
Member

ggwpez commented Feb 5, 2024

@franciscoaguirre is this still needed?

@franciscoaguirre
Copy link
Contributor

We could still create a macro for reducing the boilerplate involved with Junctions, but there's not as much anymore

@ggwpez ggwpez removed the C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. label Feb 6, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
increase pause before starting relays (paritytech#974)
deac90d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shawntabrizi @franciscoaguirre @kianenigma @ggwpez @the-right-joyce