Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trusted Teleporters and Reserves queryable through Runtime APIs #97

Open
joepetrowski opened this issue May 5, 2022 · 6 comments · Fixed by #6039
Open

Make trusted Teleporters and Reserves queryable through Runtime APIs #97

joepetrowski opened this issue May 5, 2022 · 6 comments · Fixed by #6039
Assignees
@x3c41a
Labels
I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.

Comments

@joepetrowski
Copy link
Contributor

Some applications would like to know if certain chains are Trusted Teleporters or not. This will affect how they treat DOT/KSM deposits on those chains, or on the extrinsics they construct to interact with the Relay Chain.

AFACT, one must look up the Trusted Teleporters in the source code, e.g. https://github.com/paritytech/polkadot/blob/release-v0.9.19/runtime/polkadot/src/xcm_config.rs#L114
@joepetrowski joepetrowski transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. and removed J0-enhancement labels Aug 25, 2023
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Mar 25, 2024
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/xcm-asset-registry/1168/8

jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @bkchr
fix error processing (paritytech#97)
f429051
@acatangiu acatangiu moved this to High Priority in Bridges + XCM Apr 22, 2024
@acatangiu
Copy link
Contributor

Can we expose this as runtime APIs rather than adding to Metadata?

The configuration is a filter not an actual list of (asset, location).
Metadata would have to export this filter somehow and consumers can call it offchain.
Runtime APIs can take (asset, location) and provide true/false based on filter (whether asset can be teleported to location).

Any particular benefit for one over the other?

@joepetrowski
Copy link
Contributor Author

Yeah good point, runtime API would be fine IMO. Just as long as wallets can easily get the information.

@acatangiu
Copy link
Contributor

We'll prioritize this. It's easy and important.

We'll provide runtime APIs for:

  • querying trusted teleporters
  • querying trusted reserves

@acatangiu acatangiu changed the title Make Trusted Teleporters Available in Runtime Metadata or Storage Make trusted Teleporters and Reserves queryable through Runtime APIs Oct 3, 2024
@franciscoaguirre
Copy link
Contributor

We could extend this to reserves and have another API for it. They have the same format (asset, location).

@x3c41a x3c41a mentioned this issue Oct 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
@x3c41a @franciscoaguirre
Added Trusted Query API calls (#6039)
7240b47 
Implemented is_trusted_reserve and is_trusted_teleporter API methods. 
Tested them with regular and chopstick tests.
Fixes #97

---------

Co-authored-by: Francisco Aguirre <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in Bridges + XCM Oct 17, 2024
@x3c41a x3c41a reopened this Oct 18, 2024
@x3c41a
Copy link
Contributor

x3c41a commented Oct 18, 2024

The issue will be closed once these API methods are integrated in fellowship-runtimes Polkadot and Kusama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@x3c41a x3c41a

Labels
I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Trusted Query API calls paritytech/polkadot-sdk
6 participants
@franciscoaguirre @joepetrowski @acatangiu @the-right-joyce @Polkadot-Forum @x3c41a