Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collators unconditionally queue up collation requests #963

Open
eskimor opened this issue Jul 7, 2021 · 1 comment
Open

Collators unconditionally queue up collation requests #963

eskimor opened this issue Jul 7, 2021 · 1 comment
Labels
I2-bug The node fails to follow expected behavior.

Comments

@eskimor
Copy link
Member

eskimor commented Jul 7, 2021

This enables a DoS attack vector. Ideally this would be resolved together with paritytech/polkadot#2842 by applying proper back pressure to the request channel.
@eskimor eskimor added the I3-bug label Jul 7, 2021
@eskimor eskimor mentioned this issue Jul 8, 2021
Merged
7 tasks
@eskimor
Copy link
Member Author

eskimor commented Nov 26, 2021

We should have a limit on the number of requests we queue and start dropping them when full. In practice we should not have more requests than the backing group size - so the limit can be pretty low.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I2-bug The node fails to follow expected behavior. T9-parachains_protocol and removed I3-bug labels Aug 25, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@nanocryk
check input size is a multiple of 192 (like in geth) (paritytech#963)
319f0af
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
pass source and target chain ids to account_ownership_proof (parityte…
bfd7037 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik
pass source and target chain ids to account_ownership_proof (parityte…
b81f5c8 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik
pass source and target chain ids to account_ownership_proof (parityte…
d2772e2 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
7a2759a 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
82659ef 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
a0827ed 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
c2b9776 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
640edbd 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
e030ae3 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
9ca8f63 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
5fc9369 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
45397b0 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
6e013ed 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
2814a96 
…ch#963)
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
pass source and target chain ids to account_ownership_proof (parityte…
0f4245f 
…ch#963)
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
pass source and target chain ids to account_ownership_proof (#963)
ff7f8ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior.
Projects
parachains team board
Status: Backlog
Collator Protocol Revamp
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eskimor @ordian @the-right-joyce