Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disputes: remove DISPUTE_WINDOW constant #889

Open
ordian opened this issue Dec 27, 2021 · 2 comments
Open

disputes: remove DISPUTE_WINDOW constant #889

ordian opened this issue Dec 27, 2021 · 2 comments
Assignees
@sandreim
Labels
I4-refactor Code needs refactoring.

Comments

@ordian
Copy link
Member

ordian commented Dec 27, 2021

After paritytech/polkadot#4547, we can fetch it from the runtime instead of hardcoding it as a constant in dispute-coordinator and dispute-distribution.
Approval-voting also has APPROVAL_SESSIONS which should be replaced as well.
@eskimor
Copy link
Member

eskimor commented Jan 19, 2022

Yes, otherwise the fetch would fail if the runtime config got out of sync.

@sandreim sandreim self-assigned this Oct 28, 2022
@sandreim
Copy link
Contributor

sandreim commented Oct 31, 2022 •
edited
Loading

I'm going to completely remove the session window on the node side and we will just keep sessions up to (and including) last finalized block session.

Will stack the changes on top of paritytech/polkadot#6106 which moved the constant inside the RollingSessionWindow

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
claravanstaden added a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@claravanstaden @vgeddes
@doubledup @alistair-singh @yrong
Beacon Fuzz testing (paritytech#907)
60a82e0 
* Improve contracts

* More improvements to contracts

* Fix parachain build in proxy-contracts branch (paritytech#889)

* Upgrade ssz_rs crate. (paritytech#880)

* Upgrade ssz_rs crate.

* Upgrade ssz_rs crate.

---------

Co-authored-by: claravanstaden <Cats 4 life!>

* Bump nixpkgs to use its geth package (paritytech#885)

* Bump nixpkgs to use its geth package

* Use source config in PolkadotListener

* Match field order in struct def

* Move info log to relay creation

* Remove unused channel

* Whitespace

* Add context to errors

* Add logs

* Bump node & pnpm in workflow

* Rename locals

* Remove unused variable

* Add Troubleshooting README section

* Fix up .envrc-example files

* Add note about pure shells

* Update cumulus submodule (paritytech#886)

* Inbound queue benchmarks (paritytech#876)

* Start with inbound channel benchmarks.

* Add method to set execution header storage for benchmark test.

* Working on benchmarks

* Basic working version

* Cleanup

* Removes cleanup.

* Adds some comments for Alistair.

* Adds branch name.

* Makes note

* Test transactions

* Cleaning up beacon client deps.

* Clean up comments.

* Tests cleanup.

* Fixes non-benchmark test runs.

* Cleanup.

* Update fixtures and generates benchmarks.

* Revert relayer logs.

* Cleanup BenchmarkHelper impl and inbound queue dependencies.

* fmt

* Cleanup imports.

* Cleanup imports.

* Touch

* Adds weights in inbound queue pallet.

* Fix tests.

* Update cumulus.

---------

Co-authored-by: claravanstaden <Cats 4 life!>

* Fix parachain build

* Move BalanceOf outside of pallet

* remove benchmark for non existing method

* downgrade cargo.lock to match cumulus

* fix benchmarks

---------

Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Alistair Singh <[email protected]>

* forge install: openzeppelin-contracts

v4.9.2

* sno-472 rebased (paritytech#890)

* Halting & resuming bridge pallets

* Ignore .env

* Remove .env

* Some polish

* Set owner of bridge pallets

* Upgrade ssz_rs crate. (paritytech#880)

* Upgrade ssz_rs crate.

* Upgrade ssz_rs crate.

---------

Co-authored-by: claravanstaden <Cats 4 life!>

* Update cumulus

* Bump nixpkgs to use its geth package (paritytech#885)

* Bump nixpkgs to use its geth package

* Use source config in PolkadotListener

* Match field order in struct def

* Move info log to relay creation

* Remove unused channel

* Whitespace

* Add context to errors

* Add logs

* Bump node & pnpm in workflow

* Rename locals

* Remove unused variable

* Add Troubleshooting README section

* Fix up .envrc-example files

* Add note about pure shells

* Relax RANDAO_COMMIT_DELAY for local setup

* Update cumulus

* Update cumulus submodule (paritytech#886)

* Update cumulus

* Inbound queue benchmarks (paritytech#876)

* Start with inbound channel benchmarks.

* Add method to set execution header storage for benchmark test.

* Working on benchmarks

* Basic working version

* Cleanup

* Removes cleanup.

* Adds some comments for Alistair.

* Adds branch name.

* Makes note

* Test transactions

* Cleaning up beacon client deps.

* Clean up comments.

* Tests cleanup.

* Fixes non-benchmark test runs.

* Cleanup.

* Update fixtures and generates benchmarks.

* Revert relayer logs.

* Cleanup BenchmarkHelper impl and inbound queue dependencies.

* fmt

* Cleanup imports.

* Cleanup imports.

* Touch

* Adds weights in inbound queue pallet.

* Fix tests.

* Update cumulus.

---------

Co-authored-by: claravanstaden <Cats 4 life!>

* Fix test

* Fix parachain build

* Move BalanceOf outside of pallet

* remove benchmark for non existing method

* downgrade cargo.lock to match cumulus

* fix benchmarks

* Clara/sno 552 (paritytech#887)

* Spacing

* Spacing

* Undo typo.

* Minor updates.

* Adds comment about IrrelevantUpdate.

* One more comment.

* Update error name.

---------

Co-authored-by: claravanstaden <Cats 4 life!>

* Halting & resuming bridge pallets (paritytech#883)

* Halting & resuming bridge pallets

* Ignore .env

* Remove .env

* Some polish

* Set owner of bridge pallets

* Update cumulus

* Relax RANDAO_COMMIT_DELAY for local setup

* Update cumulus

* Update cumulus

* Fix test

* Fix Warnings

* Fix test

* Fix build & format

* Fix benchmark test

* Check for duplicate versions of substrate and polkadot (paritytech#891)

* modified pre-commit

* fixes

* testing

* testing

* testing

* fixed tests

* Format

* Some fix

* Update cumulus

* Update cumulus

---------

Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: David Dunn <[email protected]>
Co-authored-by: Alistair Singh <[email protected]>

* Proxy contracts Tests fixes (paritytech#892)

* fixed tests

* warnings and imports

* rustfmt

* updated cumulus

* Revert rustfmt (paritytech#896)

* Revert "rustfmt"

This reverts commit b83cec7929cdcc6ac972a2b1cad3a0e1fde81870.

* reverted xcm-builder

* Create agent (paritytech#895)

* base

* removed location conversion

* completed implementation

* remove xcm-builder

* update cumulus

* update cumulus

* use contains_key

* Fix openzeppelin-contracts submodule

---------

Co-authored-by: David Dunn <[email protected]>

* improve API for sending tokens

* Messy working version.

* Cleanup.

* More cleanup.

* Rollback unnecessary changes.

* Cleanup whitespace.

* Fix tests.

* Fuzz the submit method.

* Revert rebase oopsies.

* More fuzzing.

* More fuzzing.

* Last extrinsic.

* Remove unnecessary dependency.

* Revert readme.

* Fix tests and feature issues.

* Cleanup types.

* More cleanup.

* Call extrinsics directly. Adds readme.

* Adds CI.

* cd to correct dir

* Update CI.

* Correct nightly param.

* Remove runs.

* Own impl for SyncCommittee.

* Remove rng.
Cleans up workflow.

* Last cleanup.

* Update parachain/pallets/ethereum-beacon-client/fuzz/Cargo.toml

Co-authored-by: David Dunn <[email protected]>

* Adds cargo-fuzz to init script.

* PR comment changes.

* Update parachain/pallets/ethereum-beacon-client/fuzz/src/impls.rs

Co-authored-by: David Dunn <[email protected]>

* Update rust-toolchain.toml

Co-authored-by: David Dunn <[email protected]>

* Update .github/workflows/parachain.yml

Co-authored-by: David Dunn <[email protected]>

* Less runs for shorter Github actions.

---------

Co-authored-by: Vincent Geddes <[email protected]>
Co-authored-by: David Dunn <[email protected]>
Co-authored-by: Alistair Singh <[email protected]>
Co-authored-by: Ron <[email protected]>
Co-authored-by: claravanstaden <Cats 4 life!>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@tomusdrw @svyatonik @HCastano
CLI: Encode Message (paritytech#889)
f8eaecf 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@tomusdrw @svyatonik @HCastano
CLI: Encode Message (paritytech#889)
e1f6ce0 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @svyatonik @HCastano
CLI: Encode Message (paritytech#889)
7c24fa2 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
bbb20da 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
7c4bf32 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
e95eb15 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
820ef49 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
d251f86 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
d51760e 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
70e5784 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
e56fbc1 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
e2a7359 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
3f4238f 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
4cf5a05 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @svyatonik
@HCastano @serban300
CLI: Encode Message (paritytech#889)
4c523d8 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
bkchr pushed a commit that referenced this issue Apr 10, 2024
@tomusdrw @svyatonik
@HCastano @bkchr
CLI: Encode Message (#889)
7c63968 
* Encode message.

* Update docs related to `sender`

Co-authored-by: Svyatoslav Nikolsky <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandreim sandreim

Labels
I4-refactor Code needs refactoring.
Projects
parachains team board
Status: Backlog
Disputes + Slashing + Rewards
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eskimor @ordian @sandreim @the-right-joyce