Fix zombienet test `zombienet-parachain-template-smoke` #6575

pepoviola · 2024-11-21T10:20:04Z

Fails from yesterday

cc: @iulianbarbu

iulianbarbu · 2024-11-21T17:52:56Z

I think the issue comes from the fact that zombienet calls the minimal-template-node build-spec command and the result is a dev-plain.json which contains some aura related configs, although this shouldn't be the case considering minimal-template-node doesn't have a runtime configured with AURA. Not sure how the aura config makes its way to minimal chain spec. I can reproduce this on master.

Looking now into finding the precise commands that run and make up towards this chain spec. Would be great to see where this stops being a problem. I couldn't find something that is relevant to the issue in the first commit where this job started failing: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7786340.

pepoviola · 2024-11-21T18:11:09Z

Thanks!! Ping me if you need help 👍

iulianbarbu · 2024-11-22T11:57:39Z

I think the issue comes from this function: https://github.com/paritytech/zombienet-sdk/blob/main/crates/orchestrator/src/generators/chain_spec.rs#L508. It does this check here: https://github.com/paritytech/zombienet-sdk/blob/main/crates/orchestrator/src/generators/chain_spec.rs#L569, but it will go on the else branch: https://github.com/paritytech/zombienet-sdk/blob/main/crates/orchestrator/src/generators/chain_spec.rs#L579, which sets up AURA and GRANDPA authorities by default.
How this fails is that the minimal_template_block_production_test calls: https://github.com/paritytech/zombienet-sdk/blob/v0.2.15/crates/orchestrator/src/lib.rs#L91, which calls https://github.com/paritytech/zombienet-sdk/blob/v0.2.15/crates/orchestrator/src/lib.rs#L129 (which generates a correct chain_spec). After that we call the function from point 1. (https://github.com/paritytech/zombienet-sdk/blob/v0.2.15/crates/orchestrator/src/lib.rs#L168), which modifies the previously generated plain chain spec, and after this function call, we call into https://github.com/paritytech/zombienet-sdk/blob/v0.2.15/crates/orchestrator/src/lib.rs#L180, which calls build-spec again but with an additional --raw flag and using the previously modified plain chain_spec, which fails with the error we saw in the failed jobs logs from the issue description.

We must release a fix where we don't assume relaychain chain specs would always want aura and grandpa authorities. I think this commit: paritytech/zombienet-sdk@cae47b2 introduced the behavior which results in failing jobs. @pepoviola any idea how to fix it?

pepoviola · 2024-11-22T13:55:10Z

Nice catch @iulianbarbu! we should only override those iff there are present. I will fix this and draft a new version (and then update it here). Thanks again for checking this.

rockbmb · 2024-11-22T15:21:20Z

Thanks @iulianbarbu and @pepoviola.

I've been curious about the Zombienet failures in CI, and also wanted to know why they occur.

@iulianbarbu

fix for paritytech/polkadot-sdk#6575 cc: @iulianbarbu

@iulianbarbu

Fix #6575. cc: @iulianbarbu Co-authored-by: Iulian Barbu <[email protected]>

@iulianbarbu

Fix paritytech#6575. cc: @iulianbarbu Co-authored-by: Iulian Barbu <[email protected]>

pepoviola added the T10-tests This PR/Issue is related to tests. label Nov 21, 2024

pepoviola mentioned this issue Nov 21, 2024

Zombienet flaky tests #5852

Open

16 tasks

pepoviola self-assigned this Nov 22, 2024

pepoviola mentioned this issue Nov 25, 2024

Override keys iff they are present paritytech/zombienet-sdk#275

Merged

pepoviola added a commit to paritytech/zombienet-sdk that referenced this issue Nov 25, 2024

Override keys iff they are present (#275)

9189d72

fix for paritytech/polkadot-sdk#6575 cc: @iulianbarbu

pepoviola mentioned this issue Nov 25, 2024

bump zombienet-sdk version v0.2.16 #6633

Merged

github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024

bump zombienet-sdk version v0.2.16 (#6633)

7f64e66

Fix #6575. cc: @iulianbarbu Co-authored-by: Iulian Barbu <[email protected]>

pepoviola closed this as completed in #6633 Nov 26, 2024

Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this issue Dec 18, 2024

bump zombienet-sdk version v0.2.16 (paritytech#6633)

93df3a1

Fix paritytech#6575. cc: @iulianbarbu Co-authored-by: Iulian Barbu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix zombienet test `zombienet-parachain-template-smoke` #6575

Fix zombienet test `zombienet-parachain-template-smoke` #6575

pepoviola commented Nov 21, 2024

iulianbarbu commented Nov 21, 2024 •

edited

Loading

pepoviola commented Nov 21, 2024

iulianbarbu commented Nov 22, 2024

pepoviola commented Nov 22, 2024

rockbmb commented Nov 22, 2024

Fix zombienet test zombienet-parachain-template-smoke #6575

Fix zombienet test zombienet-parachain-template-smoke #6575

Comments

pepoviola commented Nov 21, 2024

iulianbarbu commented Nov 21, 2024 • edited Loading

pepoviola commented Nov 21, 2024

iulianbarbu commented Nov 22, 2024

pepoviola commented Nov 22, 2024

rockbmb commented Nov 22, 2024

Fix zombienet test `zombienet-parachain-template-smoke` #6575

Fix zombienet test `zombienet-parachain-template-smoke` #6575

iulianbarbu commented Nov 21, 2024 •

edited

Loading