progress mbm on_idle #6538
Draft
progress mbm on_idle #6538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ggwpez, any feedback on this |
|
Are the phases such a big problem right now? Maybe we should finish this other pr by @ggwpez. Maybe you could take over this pr @ermalkaleci? |
|
@bkchr Yes it is a problem for chains using it. We used it on Shiden and now we have an invalid event paritytech/substrate-api-sidecar#1538 |
|
Can you test with this? Will try to get it through audit soon if you say that it fixes this. #3666 |
yes, I did some tests and it works. I want to confirm this approach makes sense so I can write some integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggwpez I propose we change the oder of MBM step to run on_idle so emitted event will have phase Finalization instead of ApplyExtrinsic. You already have a PR opened to change phasing but this one is more a short term solution. Let me know if this is all good so I can proceed with more tests