Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReportCollator message #6415

Closed
tdimitrov opened this issue Nov 8, 2024 · 0 comments · Fixed by #6628
Closed

Remove ReportCollator message #6415

tdimitrov opened this issue Nov 8, 2024 · 0 comments · Fixed by #6628
Assignees
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@tdimitrov
Copy link
Contributor

ReportCollator message is never sent by any subsystems. We should remove it along with this test

Originally posted by @alindima in #4880 (comment)

@tdimitrov tdimitrov self-assigned this Nov 8, 2024
@tdimitrov tdimitrov added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T8-polkadot This PR/Issue is related to/affects the Polkadot network. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Nov 8, 2024
@tdimitrov tdimitrov changed the title Remove ReportCollator` message Remove ReportCollator message Nov 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 25, 2024
Closes #6415 

# Description

Remove unused message `ReportCollator` and test related to this message
on the collator protocol validator side.

cc: @tdimitrov

---------

Co-authored-by: Tsvetomir Dimitrov <[email protected]>
Co-authored-by: command-bot <>
@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Nov 25, 2024
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this issue Dec 18, 2024
Closes paritytech#6415 

# Description

Remove unused message `ReportCollator` and test related to this message
on the collator protocol validator side.

cc: @tdimitrov

---------

Co-authored-by: Tsvetomir Dimitrov <[email protected]>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant