Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lazy_static with OnceLock #5641

Closed
bkchr opened this issue Sep 9, 2024 · 2 comments · Fixed by #5716
Closed

Replace lazy_static with OnceLock #5641

bkchr opened this issue Sep 9, 2024 · 2 comments · Fixed by #5716
Assignees
@programskillforverification
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@bkchr
Copy link
Member

bkchr commented Sep 9, 2024

We should be able to replace all lazy_static usages with OnceLock from the Rust standard library. This will bring us less dependencies. The lazy_static README gives an example on how to do this.
@bkchr bkchr added D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Sep 9, 2024
@programskillforverification
Copy link
Contributor

I would like to work on this, please assign to me

@bkchr
Copy link
Member Author

bkchr commented Sep 9, 2024

Done

Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2024
@programskillforverification @bkchr
Replace lazy_static with LazyLock (#5716)
a8d8596 
# Description

close #5641

---------

Co-authored-by: Bastian Köcher <[email protected]>
paritytech-ci pushed a commit that referenced this issue Oct 1, 2024
@programskillforverification @bkchr
Replace lazy_static with LazyLock (#5716)
57e8cc9 
# Description

close #5641

---------

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programskillforverification programskillforverification

Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace lazy_static with LazyLock programskillforverification/polkadot-sdk
2 participants
@bkchr @programskillforverification