Make on_idle
WeightMeter factor in block size
#4743
Labels
I2-bug
The node fails to follow expected behavior.
on_idle
WeightMeter factor in block size
#4743
We want to get rid of the current defensive limit on pov size defined here:
polkadot-sdk/cumulus/client/consensus/aura/src/collators/lookahead.rs
Line 394 in cdb297b
With #4326 in place we are already close.
There is one more scenario we need to fix before we can safely enable the full size there. It can happen that on_idle consumes more weight than what is available and exceed the PoV size.
Example for this scenario:
CheckWeight
SE: Check for extrinsic length + proof size combined #4326 reports that that no more extrinsics can be included in a block because weight + block length exceed the PoV size.on_idle
hook defined that gets called with the rest weight. However, since block length and storage proof weight are tracked separately, the remaining weight passed toon_idle
will be too high.Solutions:
CheckWeight
SE: Check for extrinsic length + proof size combined #4326. If we go this route one needs to double check the pov-reclaim logic for adjustments.The text was updated successfully, but these errors were encountered: