Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building on Windows is broken due to symbolic link #4625

Closed
2 tasks done
conr2d opened this issue May 29, 2024 · 1 comment · Fixed by #4636
Closed
2 tasks done

Building on Windows is broken due to symbolic link #4625

conr2d opened this issue May 29, 2024 · 1 comment · Fixed by #4636
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@conr2d
Copy link
Contributor

conr2d commented May 29, 2024

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

#3087 added the symbolic link pointing to docs tosubstrate/primitives/runtime, but on Windows (tested on Windows 10), symbolic link cannot be recognized, so the following line causes file not found error during compiling Substrate.

polkadot-sdk/substrate/primitives/runtime/src/generic/unchecked_extrinsic.rs

Line 60 in 89604da

#[cfg_attr(feature = "std", doc = simple_mermaid::mermaid!("../../docs/mermaid/extrinsics.mmd"))]

Steps to reproduce

Compile sp-runtime on Windows.
@conr2d conr2d added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels May 29, 2024
@bkchr
Copy link
Member

bkchr commented May 29, 2024

We don't really support Windows. However, if you have a fix, we are happy to accept your pr that fixes the issue.

@conr2d conr2d mentioned this issue May 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 30, 2024
@conr2d
Fix broken windows build (#4636)
d539778 
Fixes #4625.

Specifically, the `cfg` attribute `windows` refers to the compile target
and not the build environment, and in the case of cross-compilation, the
build environment and target can differ. However, the line modified is
related to documentation generation, so there should be no critical
issue with this change.
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@conr2d @hitchhooker
Fix broken windows build (paritytech#4636)
47f49bc 
Fixes paritytech#4625.

Specifically, the `cfg` attribute `windows` refers to the compile target
and not the build environment, and in the case of cross-compilation, the
build environment and target can differ. However, the line modified is
related to documentation generation, so there should be no critical
issue with this change.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@conr2d @TarekkMA
Fix broken windows build (paritytech#4636)
4525006 
Fixes paritytech#4625.

Specifically, the `cfg` attribute `windows` refers to the compile target
and not the build environment, and in the case of cross-compilation, the
build environment and target can differ. However, the line modified is
related to documentation generation, so there should be no critical
issue with this change.
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this issue Dec 27, 2024
@conr2d
Fix broken windows build (paritytech#4636)
db37a59 
Fixes paritytech#4625.

Specifically, the `cfg` attribute `windows` refers to the compile target
and not the build environment, and in the case of cross-compilation, the
build environment and target can differ. However, the line modified is
related to documentation generation, so there should be no critical
issue with this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken windows build conr2d/polkadot-sdk
2 participants
@bkchr @conr2d