on-demand: Improve/fix events

[eskimor]

I just checked on events in on-demand and noticed two things:

1. OnDemandOrderPlaced seems to be never triggered.
2. SpotTrafficSet This value will be largely useless for people, maybe we should have a SpotPriceSet?

[bolajahmad]

Hi, I would like to take this on. I wonder what was the intended purpose for the OnDemandOrderPlaced?

1. Should this not be added in the extrinsics like do_place_order and/or on_demand_order? I can work it in there instead of removing it altogether.
2. SpotTrafficSet is used in the update_spot_traffic call. What is the intended effect of changing the EventName to SpotPriceSet, especilly if the resulting event has the same arguments?

[eskimor]

Relevant stackexchange question: https://substrate.stackexchange.com/questions/11366/ondemandassignmentprovider-ondemandorderplaced-event-was-removed/11389#11389

What is the intended effect of changing the EventName to SpotPriceSet,

That we are not reporting the abstract spot traffic, but the actual current price. (spot traffic multiplied by base fee)

Hi, I would like to take this on.

Amazing! Thanks a lot! Happy to review!

Should this not be added in the extrinsics like do_place_order and/or on_demand_order? I can work it in there instead of removing it altogether.

I don't think we should remove it at all.

I guess we should do the following:

1. Issue OnDemandOrderPlaced whenever an order is placed - giving you the current price.
2. Issue SpotTrafficSet ... only if price changed without an order getting placed.

[cuckooemm]

OnDemandOrderPlaced it is better to add an ordering account

[cuckooemm]

If the traffic value is only used to calculate the real-time price, it is better to display the price directly. If it has other functions, just keep it like this.

[eskimor]

Thanks for the feedback! :-)

[eskimor]

@bolajahmad if you still want to take this, do you have some timeline in mind?

[bolajahmad]

@eskimor, I have been following the responses in my mail, and I am able to respond now.

I will start working on this and in a couple hours (approx 36) I will have a PR for review.

[bolajahmad]

OnDemandOrderPlaced it is better to add an ordering account

I don't get what you mean. The OnDemandOrderPlaced only expects para_id and spot_price. Are you just saying a 3rd property should be added which is the account of the orderer?

[cuckooemm]

OnDemandOrderPlaced it is better to add an ordering account

I don't get what you mean. The OnDemandOrderPlaced only expects para_id and spot_price. Are you just saying a 3rd property should be added which is the account of the orderer?

yes