Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-sensical para_id function #3948

Closed
eskimor opened this issue Apr 2, 2024 · 0 comments · Fixed by #3979
Closed

Remove non-sensical para_id function #3948

eskimor opened this issue Apr 2, 2024 · 0 comments · Fixed by #3979
Assignees
@tdimitrov

Comments

@eskimor
Copy link
Member

eskimor commented Apr 2, 2024

The para_id function returns either the occupying para id or the scheduled one. This is nonsensical, if we assume core sharing paras and should be fixed.
@eskimor eskimor mentioned this issue Apr 2, 2024
Merged
2 tasks
@tdimitrov tdimitrov mentioned this issue Apr 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
@tdimitrov @sandreim
Deprecate para_id() from CoreState in polkadot primitives (#3979)
59f868d 
With Coretime enabled we can no longer assume there is a static 1:1
mapping between core index and para id. This mapping should be obtained
from the scheduler/claimqueue on block by block basis.

This PR modifies `para_id()` (from `CoreState`) to return the scheduled
`ParaId` for occupied cores and removes its usages in the code.

Closes #3948

---------

Co-authored-by: Andrei Sandu <[email protected]>
s0me0ne-unkn0wn pushed a commit that referenced this issue Apr 8, 2024
@tdimitrov @sandreim @s0me0ne-unkn0wn
Deprecate para_id() from CoreState in polkadot primitives (#3979)
c6bfc48 
With Coretime enabled we can no longer assume there is a static 1:1
mapping between core index and para id. This mapping should be obtained
from the scheduler/claimqueue on block by block basis.

This PR modifies `para_id()` (from `CoreState`) to return the scheduled
`ParaId` for occupied cores and removes its usages in the code.

Closes #3948

---------

Co-authored-by: Andrei Sandu <[email protected]>
Ank4n pushed a commit that referenced this issue Apr 9, 2024
@tdimitrov @sandreim @Ank4n
Deprecate para_id() from CoreState in polkadot primitives (#3979)
7daeaca 
With Coretime enabled we can no longer assume there is a static 1:1
mapping between core index and para id. This mapping should be obtained
from the scheduler/claimqueue on block by block basis.

This PR modifies `para_id()` (from `CoreState`) to return the scheduled
`ParaId` for occupied cores and removes its usages in the code.

Closes #3948

---------

Co-authored-by: Andrei Sandu <[email protected]>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@tdimitrov @sandreim @dharjeezy
Deprecate para_id() from CoreState in polkadot primitives (parity…
1b024f0 
…tech#3979)

With Coretime enabled we can no longer assume there is a static 1:1
mapping between core index and para id. This mapping should be obtained
from the scheduler/claimqueue on block by block basis.

This PR modifies `para_id()` (from `CoreState`) to return the scheduled
`ParaId` for occupied cores and removes its usages in the code.

Closes paritytech#3948

---------

Co-authored-by: Andrei Sandu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdimitrov tdimitrov

Labels
None yet
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate para_id() from CoreState in polkadot primitives paritytech/polkadot-sdk
2 participants
@tdimitrov @eskimor