Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving the "order on-demand" extrinsics #3425

Closed
eskimor opened this issue Feb 21, 2024 · 2 comments · Fixed by #4706
Closed

Consider moving the "order on-demand" extrinsics #3425

eskimor opened this issue Feb 21, 2024 · 2 comments · Fixed by #4706
Assignees
@s0me0ne-unkn0wn

Comments

@eskimor
Copy link
Member

eskimor commented Feb 21, 2024

Right now it is routed directly to the "on demand assigner" pallet, which can be considered an implementation detail. Probably a good idea to move this to the the "toplevel" coretime interface pallet.

it is a bit late for Kusama, but if we want that we should do it before going for Polkadot in order to avoid breakage later on.
@eskimor eskimor converted this from a draft issue Feb 21, 2024
@eskimor eskimor changed the title Consider moving the "order on-demand" extrinsic Consider moving the "order on-demand" extrinsics Feb 21, 2024
@seadanda
Copy link
Contributor

This could be done at the same time as implementing the coretime credits, implementing the new extrinsics (credits bought on broker can be exchanged for on-demand coretime). This could replace the existing on demand assigner extrinsics as the "right" way to do it compliant with RFC-1

We can then separately disable/remove/call filter (?) the on demand assigner extrinsics on Kusama which allow buying on-demand coretime directly with KSM

@eskimor eskimor moved this from Backlog to In Progress in parachains team board Mar 19, 2024
@eskimor
Copy link
Member Author

eskimor commented Apr 5, 2024

Status @antonva - I think we agreed to just rename the pallet?

@ordian ordian moved this from In Progress to Backlog in parachains team board May 16, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this issue Jun 5, 2024
Merged
@eskimor eskimor moved this from Backlog to In Progress in parachains team board Jun 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2024
@s0me0ne-unkn0wn @antonva
Rename assigner_on_demand to on_demand (#4706)
f923443 
Closes #3425

---------

Co-authored-by: antonva <[email protected]>
Co-authored-by: command-bot <>
@github-project-automation github-project-automation bot moved this from In Progress to Completed in parachains team board Jul 22, 2024
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@s0me0ne-unkn0wn @antonva @TarekkMA
Rename assigner_on_demand to on_demand (paritytech#4706)
7d51040 
Closes paritytech#3425

---------

Co-authored-by: antonva <[email protected]>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0me0ne-unkn0wn s0me0ne-unkn0wn

Labels
None yet
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename assigner_on_demand to on_demand paritytech/polkadot-sdk
4 participants
@eskimor @antonva @seadanda @s0me0ne-unkn0wn