Broker pallet should expose sale_price through runtime api
#3413
Comments
|
Generally we can add it, but it isn't really required to have this declared centrally. The runtime api can just be declared and implemented next to the runtime. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 5, 2024
Defines a runtime api for `pallet-broker` for getting the current price of a core if there is an ongoing sale. Closes: #3413 --------- Co-authored-by: Bastian Köcher <[email protected]>
Ank4n
pushed a commit
that referenced
this issue
Apr 9, 2024
Defines a runtime api for `pallet-broker` for getting the current price of a core if there is an ongoing sale. Closes: #3413 --------- Co-authored-by: Bastian Köcher <[email protected]>
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this issue
Apr 9, 2024
Defines a runtime api for `pallet-broker` for getting the current price of a core if there is an ongoing sale. Closes: paritytech#3413 --------- Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Frontends should not be required to reimplement the logic for determining the sale price of cores, as this approach is unreliable and changes in pricing logic could make things break.
Instead, it should be possible to directly query the price from the runtime.
The text was updated successfully, but these errors were encountered: