Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] Try to calculate MaxHolds/MxFreezes automatically #2000

Open
ggwpez opened this issue Oct 24, 2023 · 2 comments
Open

[FRAME] Try to calculate MaxHolds/MxFreezes automatically #2000

ggwpez opened this issue Oct 24, 2023 · 2 comments
Assignees
@bkontur
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 24, 2023

Follow up from this discussion: #1900 (comment)
On whether we need explicit MaxHolds/MaxFreezes at all or should rather just calculate them automatically.
It would be nice if we can do this.
@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 24, 2023
@ggwpez ggwpez mentioned this issue Oct 24, 2023
Merged
@ggwpez ggwpez moved this from Backlog to Shaping up in Runtime / FRAME Oct 24, 2023
@xlc
Copy link
Contributor

xlc commented Oct 24, 2023

This is how we do it
https://github.com/AcalaNetwork/Acala/blob/53b75bd60c6be5aad98e095ca073cf964e2b75ce/primitives/src/lib.rs#L193
https://github.com/AcalaNetwork/Acala/blob/53b75bd60c6be5aad98e095ca073cf964e2b75ce/runtime/acala/src/lib.rs#L352

@bkontur
Copy link
Contributor

bkontur commented Mar 11, 2024

I just found this issue and meantime I've removed MaxHolds few weeks ago: #2657 and also I have similar issue for doing the same for MaxFreezes here: #2997

I think we could maybe close this in favor of #2997

bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
bump BridgeHubRococo/BridgeHubWococo versions (#2000)
0a30f91
@bkontur bkontur self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkontur bkontur

Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Shaping up
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xlc @bkontur @ggwpez