Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new pallets folder #128

Open
Tracked by #133
juangirini opened this issue Aug 21, 2023 · 4 comments
Open
Tracked by #133

Create new pallets folder #128

juangirini opened this issue Aug 21, 2023 · 4 comments
Assignees
@juangirini
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@juangirini
Copy link
Contributor

juangirini commented Aug 21, 2023 •
edited
Loading

Create a new folder called pallets that sits next to frame and move all pallets into it. frame folder should only contain non pallets
@juangirini juangirini mentioned this issue Aug 24, 2023
Closed
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@juangirini juangirini self-assigned this Aug 29, 2023
@juangirini juangirini added the T2-pallets This PR/Issue is related to a particular pallet. label Aug 30, 2023
@juangirini juangirini moved this from Backlog to Shaping up in Runtime / FRAME Aug 30, 2023
@juangirini
Copy link
Contributor Author

For most of the cases it is pretty straight forward what needs to be moved into pallets, but there are some that are not that clear.

  • frame-system. This is a special case, as it is actually a pallet I guess it should be moved to pallets, then does it make sense to be renamed to pallet-system? As this entire issue is a big breaking change, then it might make sense to change the name now...
  • Main crate to stay under frame but:
    • frame-benchmarking. Should frame-benchmarking-pallet-pov be taken out of benchmarking and moved under pallets? Should it be renamed to pallet-benchmarking-pov?
    • frame-election-provider-support. Same thing for pallet-election-provider-support-benchmarking, should it be moved out?
    • frame-support. I would keep everything under frame, even frame-support-test-pallet.

cc @kianenigma @ggwpez @bkchr

@ggwpez
Copy link
Member

ggwpez commented Aug 30, 2023 •
edited
Loading

I think the frame-system can stay in, its quite an integral part and we assume it to be present in a lot of places. frame-benchmarking and its testing pallet frame-benchmarking-pallet-pov can also stay in.
frame-support should also stay i guess? We only want the pallets that downstream users actually use in the pallets folder, like pallet-balances etc.

@bkchr
Copy link
Member

bkchr commented Aug 30, 2023

  • frame-system. This is a special case, as it is actually a pallet I guess it should be moved to pallets, then does it make sense to be renamed to pallet-system? As this entire issue is a big breaking change, then it might make sense to change the name now...

It is called frame-system because it is an integral part of FRAME. This should also stay this way.

@kianenigma
Copy link
Contributor

  • frame-system should be in frame
  • frame-benchmarking should be in frame. in feat: FRAME umbrella crate. #1337 you should next try and expose all the things needed to make benchmarking from frame. This will also help you understand what needs to be in ./frame. Things that we need to re-export from frame would naturally need to be in ./frame ;)
  • pallet-election-provider-support can remain in frame for now, but possibly we can move it all into sp-staking someday.

lexnv pushed a commit that referenced this issue Apr 3, 2024
@dependabot
build(deps): bump actions/checkout from 3 to 4 (#128)
3a2c7a3 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @HCastano @bkchr
Move pruning strategy to runtime level (paritytech#128)
a0c8206 
* move pruning strategy to runtim level

* cargo fmt --all

* Update modules/ethereum/src/lib.rs

Co-authored-by: Hernando Castano <[email protected]>

* finalize_headers -> finalize_and_prune_headers

* PruningStrategy::default()

* fn import_of_non_best_block_may_finalize_blocks()

Co-authored-by: Hernando Castano <[email protected]>
claravanstaden added a commit to claravanstaden/polkadot-sdk that referenced this issue Sep 19, 2024
@yrong @claravanstaden @alistair-singh
Polkadot assets on ethereum (paritytech#128)
b19c1e1 
* Register token from polkadot

* Extract AssetRegistrarMetadata

* ReserveTransfer from AssetHub

* Transfer DOT back to AssetHub

* Fix breaking tests

* Fix register token

* Increase dispatch_gas to cover the actual cost for register token

* Add ConvertAssetId to outbound router

* Rename to SendForeignToken

* Update cost

* Move Command.RegisterToken to top level

* Use VersionedLocation for storage

* Use versioned location

* TokenIdOf follow the same pattern as AgentIdOf

* Rename MintToken to TransferNativeToken

* Rename as SendNativeToken

* More refactoring

* Remove AgentExecuteCommand

* Remove TokenExists check

* Update cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs

Co-authored-by: Clara van Staden <[email protected]>

* Benchmark register_token

* More checks for the events

* More tests for send native token

* More tests describe tokenID

* More asset identifiers

* Add LocationToToken & Always use VersionedLocation

* Fix breaking tests

* Update gas cost for registering polkadot token

* Add AgentExecuteCommand back for compatibility

* Split into 2 tests each covers one direction

* Revert the change on AH

* Switch to native token on penpal for the integration

* Make fee asset as configuration parameter of the Channel

* Revert fee_asset_id as channel property

* Short epoch

* Fix integration tests

* Fix format

* Cleanup

* Register relay token

* Use relay token as fee asset

* Fix clippy

* Fix missing dependency

* Remove reanchored prefix from asset_id

* Fix test

* Fix the instruction

* Fix test

* Multi hop transfer

* Fix tests

* allow bridge hub assets

* Register token from BH directly and remove force_register_token

* Decrease gas estimation for PNA

* Cleanup

* Store Location rather than VersionedLocation

* Fix test

* Add more tests

* Revamp reanchor logic

* Improve reanchor & Fix tests

* Use secondary governance channel to register PNA

* Rename as asset location

* Use BoundVec limit size of name&symbol

* Describe location of PNA & more tests

* Add test

* Fix taplo

* More tests

* Cleanup

* Format code

* Batch rename token command

* Remove agent_id

* Rename as AssetMetadata

* Add test for penpal native token

---------

Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Alistair Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juangirini juangirini

Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.
Projects
Runtime / FRAME
Status: Shaping up
Milestone
No milestone
Development

No branches or pull requests
5 participants
@juangirini @kianenigma @bkchr @ggwpez @the-right-joyce