Skip to content

Commit

Permalink
add availability-recovery-regression-bench (customSmallerIsBetter) be…
Browse files Browse the repository at this point in the history
…nchmark result for ad86209
  • Loading branch information
github-action-benchmark committed Jun 11, 2024
1 parent 338a0cd commit eeca48a
Showing 1 changed file with 43 additions and 1 deletion.
44 changes: 43 additions & 1 deletion bench/availability-recovery-regression-bench/data.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
window.BENCHMARK_DATA = {
"lastUpdate": 1718117025982,
"lastUpdate": 1718150267493,
"repoUrl": "https://github.com/paritytech/polkadot-sdk",
"entries": {
"availability-recovery-regression-bench": [
Expand Down Expand Up @@ -11132,6 +11132,48 @@ window.BENCHMARK_DATA = {
"unit": "seconds"
}
]
},
{
"commit": {
"author": {
"name": "cheme",
"username": "cheme",
"email": "[email protected]"
},
"committer": {
"name": "GitHub",
"username": "web-flow",
"email": "[email protected]"
},
"id": "ad8620922bd7c0477b25c7dfd6fc233641cb27ae",
"message": "Append overlay optimization. (#1223)\n\nThis branch propose to avoid clones in append by storing offset and size\nin previous overlay depth.\nThat way on rollback we can just truncate and change size of existing\nvalue.\nTo avoid copy it also means that :\n\n- append on new overlay layer if there is an existing value: create a\nnew Append entry with previous offsets, and take memory of previous\noverlay value.\n- rollback on append: restore value by applying offsets and put it back\nin previous overlay value\n- commit on append: appended value overwrite previous value (is an empty\nvec as the memory was taken). offsets of commited layer are dropped, if\nthere is offset in previous overlay layer they are maintained.\n- set value (or remove) when append offsets are present: current\nappended value is moved back to previous overlay value with offset\napplied and current empty entry is overwrite (no offsets kept).\n\nThe modify mechanism is not needed anymore.\nThis branch lacks testing and break some existing genericity (bit of\nduplicated code), but good to have to check direction.\n\nGenerally I am not sure if it is worth or we just should favor\ndifferents directions (transients blob storage for instance), as the\ncurrent append mechanism is a bit tricky (having a variable length in\nfirst position means we sometime need to insert in front of a vector).\n\nFix #30.\n\n---------\n\nSigned-off-by: Alexandru Vasile <[email protected]>\nCo-authored-by: EgorPopelyaev <[email protected]>\nCo-authored-by: Alexandru Vasile <[email protected]>\nCo-authored-by: Bastian Köcher <[email protected]>\nCo-authored-by: Oliver Tale-Yazdi <[email protected]>\nCo-authored-by: joe petrowski <[email protected]>\nCo-authored-by: Liam Aharon <[email protected]>\nCo-authored-by: Kian Paimani <[email protected]>\nCo-authored-by: Branislav Kontur <[email protected]>\nCo-authored-by: Bastian Köcher <[email protected]>\nCo-authored-by: Sebastian Kunert <[email protected]>",
"timestamp": "2024-06-11T22:15:05Z",
"url": "https://github.com/paritytech/polkadot-sdk/commit/ad8620922bd7c0477b25c7dfd6fc233641cb27ae"
},
"date": 1718150238786,
"tool": "customSmallerIsBetter",
"benches": [
{
"name": "Received from peers",
"value": 307203,
"unit": "KiB"
},
{
"name": "Sent to peers",
"value": 1.6666666666666665,
"unit": "KiB"
},
{
"name": "availability-recovery",
"value": 12.923715275200001,
"unit": "seconds"
},
{
"name": "test-environment",
"value": 0.17326682760000003,
"unit": "seconds"
}
]
}
]
}
Expand Down

0 comments on commit eeca48a

Please sign in to comment.