Skip to content

Commit

Permalink
doc: update prdoc
Browse files Browse the repository at this point in the history
  • Loading branch information
franciscoaguirre committed Nov 29, 2024
1 parent 899b995 commit e63ea59
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions prdoc/pr_6643.prdoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ title: Added fallback_max_weight to Transact for sending messages to V4 chains
doc:
- audience: Runtime Dev
description: |-
Removing the `require_weight_at_most` parameter in V5 Transact introduced a problem when converting a message from V5 to V4 to send to chains that didn't upgrade yet. The local chain doesn't know how to decode call for remote chain so it can't automatically populate `require_weight_at_most` required by V4 Transact.
To fix this, XCM v5 Transact now also takes a `fallback_max_weight: Option<Weight>` parameter. This can be set to `None` if the instruction is not meant to be sent to chains running XCM versions lower than V5. If set to `Some(w)`, a subsequent conversion to V4 will result in `Transact { require_weight_at_most: w, .. }`. The plan is to remove this workaround in V6 since there will be a good conversion path from V6 to V5.
Removing the `require_weight_at_most` parameter in V5 Transact introduced a problem when converting a message from V5 to V4 to send to chains that didn't upgrade yet.
The local chain doesn't know how to decode calls for remote chains so it can't automatically populate `require_weight_at_most` required by V4 Transact.
To fix this, XCM v5 Transact now also takes a `fallback_max_weight: Option<Weight>` parameter.
This can be set to `None` if the instruction is not meant to be sent to chains running XCM versions lower than V5.
If set to `Some(w)`, a subsequent conversion to V4 will result in `Transact { require_weight_at_most: w, .. }`.
The plan is to remove this workaround in V6 since there will be a good conversion path from V6 to V5.
crates:
- name: snowbridge-router-primitives
bump: major
Expand Down

0 comments on commit e63ea59

Please sign in to comment.