Skip to content

Commit

Permalink
Merge branch 'master' into rb-claim-commission-other
Browse files Browse the repository at this point in the history
  • Loading branch information
Ross Bulat authored Nov 25, 2023
2 parents 1af86b7 + ffc64fd commit d990e1d
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/review-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ rules:
- ^\.config/nextest.toml
- ^\.cargo/.*
exclude:
- ^./gitlab/pipeline/zombienet.*
- ^\.gitlab/pipeline/zombienet.*
minApprovals: 2
type: basic
teams:
Expand Down
2 changes: 1 addition & 1 deletion .gitlab/pipeline/zombienet.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.zombienet-refs:
extends: .build-refs
variables:
ZOMBIENET_IMAGE: "docker.io/paritytech/zombienet:v1.3.82"
ZOMBIENET_IMAGE: "docker.io/paritytech/zombienet:v1.3.83"

include:
# substrate tests
Expand Down
2 changes: 2 additions & 0 deletions .gitlab/pipeline/zombienet/cumulus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
needs:
- job: build-push-image-test-parachain
artifacts: true
- job: build-push-image-polkadot-debug
artifacts: true
variables:
POLKADOT_IMAGE: "docker.io/paritypr/polkadot-debug:${DOCKER_IMAGES_VERSION}"
GH_DIR: "https://github.com/paritytech/cumulus/tree/${CI_COMMIT_SHORT_SHA}/zombienet/tests"
Expand Down
14 changes: 14 additions & 0 deletions cumulus/client/cli/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,13 @@ impl sc_cli::CliConfiguration for ExportGenesisStateCommand {
fn shared_params(&self) -> &sc_cli::SharedParams {
&self.shared_params
}

fn base_path(&self) -> sc_cli::Result<Option<BasePath>> {
// As we are just exporting the genesis wasm a tmp database is enough.
//
// As otherwise we may "pollute" the global base path.
Ok(Some(BasePath::new_temp_dir()?))
}
}

/// Command for exporting the genesis wasm file.
Expand Down Expand Up @@ -266,6 +273,13 @@ impl sc_cli::CliConfiguration for ExportGenesisWasmCommand {
fn shared_params(&self) -> &sc_cli::SharedParams {
&self.shared_params
}

fn base_path(&self) -> sc_cli::Result<Option<BasePath>> {
// As we are just exporting the genesis wasm a tmp database is enough.
//
// As otherwise we may "pollute" the global base path.
Ok(Some(BasePath::new_temp_dir()?))
}
}

fn validate_relay_chain_url(arg: &str) -> Result<Url, String> {
Expand Down

0 comments on commit d990e1d

Please sign in to comment.