Revert metadata renames

Signed-off-by: georgepisaltu <[email protected]>

substrate/frame/support/procedural/src/construct_runtime/expand/metadata.rs

@@ -128,7 +128,7 @@ pub fn expand_runtime_metadata(
 								.map(|meta| #scrate::__private::metadata_ir::TransactionExtensionMetadataIR {
 									identifier: meta.identifier,
 									ty: meta.ty,
-									implicit: meta.implicit,
+									additional_signed: meta.additional_signed,
 								})
 								.collect(),
 					},

substrate/frame/support/test/tests/construct_runtime.rs

@@ -815,7 +815,7 @@ fn test_metadata() {
 		ty: meta_type::<UncheckedExtrinsic>(),
 		version: 4,
 		signed_extensions: vec![SignedExtensionMetadata {
-			identifier: "UnitSignedExtension",
+			identifier: "UnitTransactionExtension",
 			ty: meta_type::<()>(),
 			additional_signed: meta_type::<()>(),
 		}],

substrate/primitives/metadata-ir/src/types.rs

@@ -189,15 +189,15 @@ impl IntoPortable for ExtrinsicMetadataIR {
 	}
 }
 
-/// Metadata of an extrinsic's transaction extension.
+/// Metadata of an extrinsic's signed extension.
 #[derive(Clone, PartialEq, Eq, Encode, Debug)]
 pub struct TransactionExtensionMetadataIR<T: Form = MetaForm> {
-	/// The unique transaction extension identifier, which may be different from the type name.
+	/// The unique signed extension identifier, which may be different from the type name.
 	pub identifier: T::String,
-	/// The type of the transaction extension, with the data to be included in the extrinsic.
+	/// The type of the signed extension, with the data to be included in the extrinsic.
 	pub ty: T::Type,
-	/// The type of the implicit data, with the data to be included in the signed payload.
-	pub implicit: T::Type,
+	/// The type of the additional signed data, with the data to be included in the signed payload.
+	pub additional_signed: T::Type,
 }
 
 impl IntoPortable for TransactionExtensionMetadataIR {
@@ -207,7 +207,7 @@ impl IntoPortable for TransactionExtensionMetadataIR {
 		TransactionExtensionMetadataIR {
 			identifier: self.identifier.into_portable(registry),
 			ty: registry.register_type(&self.ty),
-			implicit: registry.register_type(&self.implicit),
+			additional_signed: registry.register_type(&self.additional_signed),
 		}
 	}
 }

substrate/primitives/metadata-ir/src/v14.rs

@@ -142,7 +142,7 @@ impl From<TransactionExtensionMetadataIR> for SignedExtensionMetadata {
 		SignedExtensionMetadata {
 			identifier: ir.identifier,
 			ty: ir.ty,
-			additional_signed: ir.implicit,
+			additional_signed: ir.additional_signed,
 		}
 	}
 }

substrate/primitives/metadata-ir/src/v15.rs

@@ -92,7 +92,7 @@ impl From<TransactionExtensionMetadataIR> for SignedExtensionMetadata {
 		SignedExtensionMetadata {
 			identifier: ir.identifier,
 			ty: ir.ty,
-			additional_signed: ir.implicit,
+			additional_signed: ir.additional_signed,
 		}
 	}
 }

substrate/primitives/runtime/src/traits/mod.rs

@@ -1602,7 +1602,7 @@ pub trait SignedExtension:
 		sp_std::vec![TransactionExtensionMetadata {
 			identifier: Self::IDENTIFIER,
 			ty: scale_info::meta_type::<Self>(),
-			implicit: scale_info::meta_type::<Self::AdditionalSigned>()
+			additional_signed: scale_info::meta_type::<Self::AdditionalSigned>()
 		}]
 	}
 

substrate/primitives/runtime/src/traits/transaction_extension/mod.rs

@@ -92,7 +92,7 @@ pub trait TransactionExtensionBase: TransactionExtensionInterior {
 			identifier: Self::IDENTIFIER,
 			ty: scale_info::meta_type::<Self>(),
 			// TODO: Metadata-v16: Rename to "implicit"
-			implicit: scale_info::meta_type::<Self::Implicit>()
+			additional_signed: scale_info::meta_type::<Self::Implicit>()
 		}]
 	}
 }
@@ -361,7 +361,8 @@ pub struct TransactionExtensionMetadata {
 	/// The type of the [`TransactionExtension`].
 	pub ty: MetaType,
 	/// The type of the [`TransactionExtension`] additional signed data for the payload.
-	pub implicit: MetaType,
+	// TODO: Rename "implicit"
+	pub additional_signed: MetaType,
 }
 
 #[impl_for_tuples(1, 12)]