pvf runtime construction error handling during execution: review comm…

…ents

polkadot/node/core/pvf/common/src/execute.rs

@@ -71,8 +71,8 @@ pub enum JobResponse {
 		/// The result of parachain validation.
 		result_descriptor: ValidationResult,
 	},
-	/// A possibly transient runtime instantion error happend during the execution; maybe retried
-	/// with preparation
+	/// A possibly transient runtime instantiation error happened during the execution; may be retried
+	/// with re-preparation
 	RuntimeConstruction(String),
 	/// The candidate is invalid.
 	InvalidCandidate(String),

polkadot/node/core/pvf/src/host.rs

@@ -860,9 +860,15 @@ async fn handle_artifact_removal(
 	artifact_id: ArtifactId,
 	reply_to: oneshot::Sender<()>,
 ) -> Result<(), Fatal> {
-	let (artifact_id, path) = artifacts
-		.remove(artifact_id)
-		.expect("artifact sent by the execute queue for removal exists; qed");
+	let (artifact_id, path) = if let Some(artifact) = artifacts.remove(artifact_id) {
+		artifact
+	} else {
+		// if we haven't found the artifact by its id,
+		// it has been probably removed
+		// anyway with the randomness of the artifact name
+		// it is safe to ignore
+		return Ok(());
+	};
 	reply_to
 		.send(())
 		.expect("the execute queue waits for the artifact remove confirmation; qed");