-
Notifications
You must be signed in to change notification settings - Fork 740
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pallet-migrations: fix index access for singluar migrations (#5695)
Discovered a bug in the migrations pallet while debugging paritytech/try-runtime-cli#90. It only occurs when a single MBM is configured - hence it did not happen when Ajuna Network tried it... Changes: - Check len of the tuple before accessing its nth_id - Make nth_id return `None` on unary tuples and n>0 --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: ggwpez <[email protected]> (cherry picked from commit 0136463)
- Loading branch information
1 parent
c1b1394
commit 8781c7a
Showing
4 changed files
with
50 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
title: 'pallet-migrations: fix index access for singluar migrations' | ||
doc: | ||
- audience: Runtime Dev | ||
description: |- | ||
Discovered a bug in the migrations pallet while debugging https://github.com/paritytech/try-runtime-cli/pull/90. | ||
It only occurs when a single MBM is configured - hence it did not happen when Ajuna Network tried it... | ||
|
||
Changes: | ||
- Check len of the tuple before accessing its nth_id | ||
- Make nth_id return `None` on unary tuples and n>0 | ||
crates: | ||
- name: pallet-migrations | ||
bump: patch | ||
- name: frame-support | ||
bump: patch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters