Remove errors on warnings on CI

.gitlab/pipeline/build.yml

@@ -14,7 +14,7 @@ build-linux-stable:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
     # Ensure we run the UI tests.
     RUN_UI_TESTS: 1
   script:
@@ -169,7 +169,7 @@ build-linux-stable-cumulus:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - echo "___Building a binary, please refrain from using it in production since it goes with the debug assertions.___"
     - time cargo build --release --locked -p polkadot-parachain-bin --bin polkadot-parachain
@@ -189,7 +189,7 @@ build-test-parachain:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - echo "___Building a binary, please refrain from using it in production since it goes with the debug assertions.___"
     - time cargo build --release --locked -p cumulus-test-service --bin test-parachain

.gitlab/pipeline/test.yml

@@ -16,7 +16,7 @@ test-linux-stable:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   parallel: 3
   script:
     # Build all but only execute 'runtime' tests.
@@ -66,7 +66,7 @@ test-linux-stable-runtime-benchmarks:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - time cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet
 
@@ -81,7 +81,7 @@ test-linux-stable-runtime-benchmarks:
 #     RUST_TOOLCHAIN: stable
 #     # Enable debug assertions since we are running optimized builds for testing
 #     # but still want to have debug assertions.
-#     RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+#     RUSTFLAGS: "-Cdebug-assertions=y"
 #   parallel: 3
 #   script:
 #     # Build all but only execute 'runtime' tests.
@@ -108,7 +108,7 @@ test-linux-stable-additional-tests:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     # tests were moved to test-linux-stable
     # the jobs should be removed
@@ -128,7 +128,7 @@ test-linux-stable-slow:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     # tests were moved to test-linux-stable
     # the jobs should be removed
@@ -148,7 +148,7 @@ test-linux-stable-slow:
 #     RUST_TOOLCHAIN: stable
 #     # Enable debug assertions since we are running optimized builds for testing
 #     # but still want to have debug assertions.
-#     RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+#     RUSTFLAGS: "-Cdebug-assertions=y"
 #   script:
 #     - mkdir -p artifacts
 #     - time cargo test --workspace
@@ -169,7 +169,7 @@ test-doc:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - time cargo test --doc --workspace
 
@@ -207,7 +207,7 @@ test-node-metrics:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     # Build the required workers.
     - cargo build --bin polkadot-execute-worker --bin polkadot-prepare-worker --profile testnet --verbose --locked
@@ -439,7 +439,6 @@ cargo-check-each-crate:
     - .run-immediately
     # - .collect-artifacts
   variables:
-    RUSTFLAGS: "-D warnings"
     # $CI_JOB_NAME is set manually so that cache could be shared for all jobs
     # "cargo-check-each-crate I/N" jobs
     CI_JOB_NAME: cargo-check-each-crate