Fix approval-voting canonicalize off by one #12152
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Short benchmarks (frame-omni-bencher) | |
| on: | |
| push: | |
| branches: | |
| - master | |
| pull_request: | |
| types: [opened, synchronize, reopened, ready_for_review, labeled] | |
| merge_group: | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
| cancel-in-progress: true | |
| env: | |
| ARTIFACTS_NAME: frame-omni-bencher-artifacts | |
| jobs: | |
| preflight: | |
| uses: ./.github/workflows/reusable-preflight.yml | |
| quick-benchmarks-omni: | |
| runs-on: ${{ needs.preflight.outputs.RUNNER_BENCHMARK }} | |
| needs: [preflight] | |
| if: ${{ needs.preflight.outputs.changes_rust }} | |
| env: | |
| RUSTFLAGS: "-C debug-assertions" | |
| RUST_BACKTRACE: "full" | |
| WASM_BUILD_NO_COLOR: 1 | |
| WASM_BUILD_RUSTFLAGS: "-C debug-assertions" | |
| RUST_LOG: "frame_omni_bencher=info,polkadot_sdk_frame=info" | |
| timeout-minutes: 30 | |
| container: | |
| image: ${{ needs.preflight.outputs.IMAGE }} | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: script | |
| id: required | |
| run: | | |
| forklift cargo build --locked --quiet --release -p asset-hub-westend-runtime --features runtime-benchmarks | |
| forklift cargo run --locked --release -p frame-omni-bencher --quiet -- v1 benchmark pallet --runtime target/release/wbuild/asset-hub-westend-runtime/asset_hub_westend_runtime.compact.compressed.wasm --all --steps 2 --repeat 1 --quiet | |
| - name: Stop all workflows if failed | |
| if: ${{ failure() && steps.required.conclusion == 'failure' && !github.event.pull_request.head.repo.fork }} | |
| uses: ./.github/actions/workflow-stopper | |
| with: | |
| app-id: ${{ secrets.WORKFLOW_STOPPER_RUNNER_APP_ID }} | |
| app-key: ${{ secrets.WORKFLOW_STOPPER_RUNNER_APP_KEY }} | |
| runtime-matrix: | |
| runs-on: ubuntu-latest | |
| needs: [preflight] | |
| if: ${{ needs.preflight.outputs.changes_rust }} | |
| timeout-minutes: 30 | |
| outputs: | |
| runtime: ${{ steps.runtime.outputs.runtime }} | |
| container: | |
| image: ${{ needs.preflight.outputs.IMAGE }} | |
| name: Extract runtimes from matrix | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - id: runtime | |
| run: | | |
| RUNTIMES=$(jq '[.[] | select(.package != null)]' .github/workflows/runtimes-matrix.json) | |
| RUNTIMES=$(echo $RUNTIMES | jq -c .) | |
| echo "runtime=$RUNTIMES" | |
| echo "runtime=$RUNTIMES" >> $GITHUB_OUTPUT | |
| run-frame-omni-bencher: | |
| runs-on: ${{ needs.preflight.outputs.RUNNER_BENCHMARK }} | |
| needs: [preflight, runtime-matrix] | |
| if: ${{ needs.preflight.outputs.changes_rust }} | |
| timeout-minutes: 30 | |
| strategy: | |
| fail-fast: false # keep running other workflows even if one fails, to see the logs of all possible failures | |
| matrix: | |
| runtime: ${{ fromJSON(needs.runtime-matrix.outputs.runtime) }} | |
| container: | |
| image: ${{ needs.preflight.outputs.IMAGE }} | |
| env: | |
| PACKAGE_NAME: ${{ matrix.runtime.package }} | |
| FLAGS: ${{ matrix.runtime.bench_flags }} | |
| RUST_LOG: "frame_omni_bencher=info,polkadot_sdk_frame=info" | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: script | |
| id: required | |
| run: | | |
| RUNTIME_BLOB_NAME=$(echo $PACKAGE_NAME | sed 's/-/_/g').compact.compressed.wasm | |
| RUNTIME_BLOB_PATH=./target/release/wbuild/$PACKAGE_NAME/$RUNTIME_BLOB_NAME | |
| forklift cargo build --release --locked -p $PACKAGE_NAME -p frame-omni-bencher --features=${{ matrix.runtime.bench_features }} --quiet | |
| echo "Running short benchmarking for PACKAGE_NAME=$PACKAGE_NAME and RUNTIME_BLOB_PATH=$RUNTIME_BLOB_PATH" | |
| ls -lrt $RUNTIME_BLOB_PATH | |
| cmd="./target/release/frame-omni-bencher v1 benchmark pallet --runtime $RUNTIME_BLOB_PATH --all --steps 2 --repeat 1 $FLAGS" | |
| echo "Running command: $cmd" | |
| eval "$cmd" | |
| - name: Stop all workflows if failed | |
| if: ${{ failure() && steps.required.conclusion == 'failure' && !github.event.pull_request.head.repo.fork }} | |
| uses: ./.github/actions/workflow-stopper | |
| with: | |
| app-id: ${{ secrets.WORKFLOW_STOPPER_RUNNER_APP_ID }} | |
| app-key: ${{ secrets.WORKFLOW_STOPPER_RUNNER_APP_KEY }} | |
| confirm-frame-omni-benchers-passed: | |
| runs-on: ubuntu-latest | |
| name: All benchmarks passed | |
| needs: [quick-benchmarks-omni, run-frame-omni-bencher] | |
| if: always() && !cancelled() | |
| steps: | |
| - run: | | |
| tee resultfile <<< '${{ toJSON(needs) }}' | |
| FAILURES=$(cat resultfile | grep '"result": "failure"' | wc -l) | |
| if [ $FAILURES -gt 0 ]; then | |
| echo "### At least one required job failed ❌" >> $GITHUB_STEP_SUMMARY | |
| exit 1 | |
| else | |
| echo '### Good job! All the required jobs passed 🚀' >> $GITHUB_STEP_SUMMARY | |
| fi |