Introduce try-runtime-bot script #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both try-runtime-bot and bench-bot have a feature request for patching some dependency into the branch before executing the command: paritytech/command-bot#83, #41. Moreover, the bots both execute some command for the core project's CLIs, so their pre-command preparation end up also being very similar. That being the case it makes sense to create a set of functions for providing shared functionality for both (tip: it's in cmd_runner.sh).
The
try-runtimeconfiguration is hardcoded directly into command-bot at the moment (https://github.com/paritytech/command-bot/blob/6245603b60e264f9663e9e2a5059225ae8709aa7/src/core.ts#L39), which means we have to redeploy the bot when the command needs to be tweaked; that is not as flexible as bench-bot since the latter can be tweaked promptly by submitting a PR to this repository. We can alleviate this problem by also creating a script for the try-runtime-bot.In summary
related to paritytech/command-bot#90
related to paritytech/command-bot#83
close #41