Update all packages in one go instead of one-by-one #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create update_crates function
joao-paulo-parity
changed the title
| @@ -322,9 +332,7 @@ patch_and_check_dependent() { | |||
| # Update the crates to the latest version. This is for example needed if there | |||
| # was a PR to Substrate which only required a Polkadot companion and Cumulus | |||
| # wasn't yet updated to use the latest commit of Polkadot. | |||
| for update in $update_crates_on_default_branch; do | |||
| cargo update -p "$update" | |||
There was a problem hiding this comment.
@bkchr is it necessary for packages to be updated one by one or could all of them be updated in one go as done in update_crates?
There was a problem hiding this comment.
They can all be updated together 👍
bkchr
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitUpdate: I thought there was a problem with$update_crates_on_default_branchthrough shell expansion so that it can be used properly withcargo -p.for var in $stringfrom local testing but it turns out my tests were wrong.This PR would change the current behavior and make all the packages update in one go instead of one by one. Originally it was created for paritytech/polkadot#4928 but it's not strictly needed.
This change should also "just work" for other existing repositories which are not Polkadot e.g. https://github.com/paritytech/substrate/blob/b2f76e26a9e8cd0d5457058b20bb250d092a16ac/.gitlab-ci.yml#L555