Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[stable] Optimize JS build #8093

Merged
merged 4 commits into from
Mar 13, 2018
Merged

[stable] Optimize JS build #8093

merged 4 commits into from
Mar 13, 2018

Conversation

tomusdrw
Copy link
Collaborator

Introduces common chunk between bundle.js and embed.js (should save ~3MB)

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Mar 12, 2018
@@ -38,7 +37,6 @@ function getPlugins (_isProd = isProd) {
const plugins = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPlugins only takes 1 argument here, but has 2 when it's called.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks! Leftovers from previous approach.

Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. M7-ui and removed A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 13, 2018
@tomusdrw tomusdrw merged commit a6d732e into stable Mar 13, 2018
@tomusdrw tomusdrw deleted the td-optimize-js-build branch March 13, 2018 15:54
@andresilva andresilva mentioned this pull request Mar 16, 2018
14 tasks
@5chdn 5chdn modified the milestones: 1.11, Patch Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants