[stable] Optimize JS build (#8093)

* Extract common chunks plugin.

* Fix common CSS.

* Fix js push for stable.

* Remove arguments to getPlugins.

js/package.json

@@ -21,10 +21,10 @@
     "Parity"
   ],
   "scripts": {
-    "build": "npm run build:inject && npm run build:app && npm run build:embed",
+    "build": "npm run build:inject && npm run build:app:embed",
     "build:app": "webpack --config webpack/app",
     "build:inject": "webpack --config webpack/inject",
-    "build:embed": "cross-env EMBED=1 node webpack/embed",
+    "build:app:embed": "cross-env EMBED=1 node webpack/embed",
     "build:i18n": "npm run clean && npm run build && babel-node ./scripts/build-i18n.js",
     "ci:build": "cross-env NODE_ENV=production npm run build",
     "clean": "rimraf ./.build ./.coverage ./.happypack",

js/scripts/push-cargo.sh

@@ -4,7 +4,7 @@ set -e
 # variables
 PVER="1-9"
 UTCDATE=`date -u "+%Y%m%d-%H%M%S"`
-BRANCH="beta"
+BRANCH="stable"
 GIT_PARITY="https://${GITHUB_JS_PRECOMPILED}:@github.com/paritytech/parity.git"
 
 echo "*** [cargo] Setting up GitHub config for parity"

js/webpack/app.js

@@ -19,6 +19,7 @@ const fs = require('fs');
 const path = require('path');
 const rimraf = require('rimraf');
 const flatten = require('lodash.flatten');
+const webpack = require('webpack');
 // const ReactIntlAggregatePlugin = require('react-intl-aggregate-webpack-plugin');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
 const WebpackErrorNotificationPlugin = require('webpack-error-notification');
@@ -47,9 +48,10 @@ const EMBED = process.env.EMBED;
 const isProd = ENV === 'production';
 const isEmbed = EMBED === '1' || EMBED === 'true';
 
-const entry = isEmbed
-  ? { embed: ['babel-polyfill', './embed.js'] }
-  : { bundle: ['babel-polyfill', './index.parity.js'] };
+const entry = {
+  embed: ['babel-polyfill', './embed.js'],
+  bundle: ['babel-polyfill', './index.parity.js']
+};
 
 module.exports = {
   cache: !isProd,
@@ -164,23 +166,30 @@ module.exports = {
   },
 
   plugins: (function () {
-    let plugins = Shared.getPlugins().concat(
-      new WebpackErrorNotificationPlugin(),
-      new ExtractTextPlugin({
-        filename: `${isEmbed ? 'embed' : 'bundle'}.css`
-      }),
-    );
-
-    if (!isEmbed) {
-      plugins = [].concat(
-        plugins,
+    let plugins = []
+      .concat(Shared.getPlugins())
+      .concat(
+        new WebpackErrorNotificationPlugin(),
+        new ExtractTextPlugin({
+          filename: '[name].css',
+          allChunks: true
+        })
+      )
+      .concat(
+        new HtmlWebpackPlugin({
+          title: 'Parity Bar',
+          filename: 'embed.html',
+          template: './index.parity.ejs',
+          favicon: FAVICON,
+          chunks: ['commons', 'embed']
+        }),
 
         new HtmlWebpackPlugin({
           title: 'Parity',
           filename: 'index.html',
           template: './index.parity.ejs',
           favicon: FAVICON,
-          chunks: ['bundle']
+          chunks: ['commons', 'bundle']
         }),
 
         new CopyWebpackPlugin(
@@ -246,16 +255,11 @@ module.exports = {
           {}
         )
       );
-    }
 
-    if (isEmbed) {
-      plugins.push(
-        new HtmlWebpackPlugin({
-          title: 'Parity Bar',
-          filename: 'embed.html',
-          template: './index.parity.ejs',
-          favicon: FAVICON,
-          chunks: ['embed']
+    if (isProd) {
+      plugins.unshift(
+        new webpack.optimize.CommonsChunkPlugin({
+          name: 'commons'
         })
       );
     }

js/webpack/shared.js

@@ -19,7 +19,6 @@ const webpack = require('webpack');
 const HappyPack = require('happypack');
 const PackageJson = require('../package.json');
 
-const EMBED = process.env.EMBED;
 const ENV = process.env.NODE_ENV || 'development';
 const isProd = ENV === 'production';
 const UI_VERSION = PackageJson
@@ -38,7 +37,6 @@ function getPlugins (_isProd = isProd) {
   const plugins = [
     new webpack.DefinePlugin({
       'process.env': {
-        EMBED: JSON.stringify(EMBED),
         NODE_ENV: JSON.stringify(ENV),
         RPC_ADDRESS: JSON.stringify(process.env.RPC_ADDRESS),
         PARITY_URL: JSON.stringify(process.env.PARITY_URL),