Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

standalone dir crate, replaces #7383 #7409

Merged
merged 6 commits into from
Dec 29, 2017
Merged

standalone dir crate, replaces #7383 #7409

merged 6 commits into from
Dec 29, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Dec 29, 2017 •
edited
Loading

replaces #7383

Nicolas Ochem and others added 6 commits December 26, 2017 00:54
Fix #6209 - introduce standalone dir crate
2e12a2d 
* created the dir crate in util
* moved code from ethstore/src/dir/paths.rs to dir crate
* rename dir module in ethstore to accounts_dir to distinguish it
  from the dir crate
* changes after @tomusdrw on #6952
move helper functions to platform module
268e8f5
Add doc everywhere, warn on missing docs
a8001ab
use platform module as intended
a4a9c53
move constants to platform-specific module too
0957349
@debris
Merge branch 'master' into dircrate2
7b40f1c
@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 29, 2017
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 29, 2017
@debris debris merged commit 5fee880 into master Dec 29, 2017
@debris debris deleted the dircrate2 branch December 29, 2017 10:44
@5chdn 5chdn added this to the 1.9 milestone Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @tomusdrw @5chdn