Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

parity/dir.rs should be a standalone crate #6209

Closed
debris opened this issue Aug 1, 2017 · 2 comments
Closed

parity/dir.rs should be a standalone crate #6209

debris opened this issue Aug 1, 2017 · 2 comments
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
1.9 Velocity

Comments

@debris
Copy link
Collaborator

debris commented Aug 1, 2017

and it should be used by ethstore instead of ethstore/src/dir/paths.rs
@debris debris added F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Aug 1, 2017
@debris debris mentioned this issue Aug 1, 2017
Closed
@5chdn 5chdn added the P7-nicetohave 🐕 Issue is worth doing eventually. label Sep 4, 2017
@asymmetric
Copy link
Contributor

asymmetric commented Oct 4, 2017 •
edited
Loading

Hi, I'm trying to take this issue and I have a question. At the moment there are 3 files that seem to contain helper functions dealing with paths:

My questions are:

  • Should all paths-related functions from those modules be moved to a new crate?
  • Where should the crate live? util::path seems like a good place :)

@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
@kirushik
Copy link
Collaborator

@asymmetric Hi!
What's your status with this issue? Do you need any help in finalizing your work?

Please keep in mind that only PRs submitted in October (which ends tomorrow) qualify for Hacktoberfest.

nicolasochem pushed a commit to nicolasochem/parity that referenced this issue Nov 1, 2017
Fix openethereum#6209 - introduce standalone dir crate
0cb617d 
Done so far:

* created the dir crate in util
* moved code from `ethstore/src/dir/paths.rs` to dir crate
* rename `dir` module in ethstore to `accounts_dir` to distinguish it
  from the dir crate

Is there a need to mutualize some code in the newly created
`util/dir/src/lib.rs` ? If so, I would need some guidance as of which
functions are to be mutualized.
nicolasochem pushed a commit to nicolasochem/parity that referenced this issue Nov 1, 2017
Fix openethereum#6209 - introduce standalone dir crate
6685af9 
Done so far:

* created the dir crate in util
* moved code from `ethstore/src/dir/paths.rs` to dir crate
* rename `dir` module in ethstore to `accounts_dir` to distinguish it
  from the dir crate

Is there a need to mutualize some code in the newly created
`util/dir/src/lib.rs` ? If so, I would need some guidance as of which
functions are to be mutualized.
nicolasochem pushed a commit to nicolasochem/parity that referenced this issue Dec 26, 2017
Fix openethereum#6209 - introduce standalone dir crate
1e99603 
* created the dir crate in util
* moved code from ethstore/src/dir/paths.rs to dir crate
* rename dir module in ethstore to accounts_dir to distinguish it
  from the dir crate
* changes after @tomusdrw on openethereum#6952
@debris debris closed this as completed in 2e12a2d Dec 29, 2017
@5chdn 5chdn modified the milestones: 1.10, 1.9 Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
1.9 Velocity
Development

No branches or pull requests
4 participants
@asymmetric @kirushik @debris @5chdn