This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Snapshot creation and restoration #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
Changes Unknown when pulling d48e262 on rphmeier:pv64 into * on ethcore:master*. |
|
CLI snapshot height default to 1000 blocks earlier |
| @@ -50,7 +50,7 @@ | |||
| //! ); | |||
| //! let client = Client::new( | |||
| //! ClientConfig::default(), | |||
| //! ethereum::new_frontier(), | |||
| //! ðereum::new_frontier(), | |||
There was a problem hiding this comment.
is this directly related to snapshotting? if not, perhaps a list of any other refactoring/changes made would be helpful, plus comments to guide through the PR would speed along the review process
There was a problem hiding this comment.
it wasn't directly related, although it was useful to assist in adding the SnapshotService to ClientService without loading the spec twice. i will refactor it out into another PR.
arkpar
added
A8-looksgood 🦄
|
one minor grumble |
[ci skip]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1557
The informant is still a little weak, especially on the snapshot creation side of things. This will come in a future PR.