Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

miner and client take spec reference #1853

Merged
merged 3 commits into from
Aug 5, 2016
Merged

miner and client take spec reference #1853

merged 3 commits into from
Aug 5, 2016

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Aug 5, 2016 •
edited
Loading

this is done by making the engine field of Spec into an Arc.

this is part of #1679 which is being refactored out.

@rphmeier rphmeier added the A0-pleasereview 🤓 Pull request needs code review. label Aug 5, 2016
@coveralls
Copy link

coveralls commented Aug 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 86.765% when pulling caa74e7 on spec-arc-engine into 725d320 on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 5, 2016
@gavofyork
Copy link
Contributor

guess this can be closed now that #1679 is merged.

@gavofyork gavofyork closed this Aug 5, 2016
@rphmeier
Copy link
Contributor Author

rphmeier commented Aug 5, 2016

actually, #1679 didn't include the miner changes; I just figured I would do both in this PR.

@rphmeier rphmeier reopened this Aug 5, 2016
@coveralls
Copy link

coveralls commented Aug 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 86.307% when pulling 1d8da9c on spec-arc-engine into 46a988d on master.

@gavofyork gavofyork merged commit e72fc53 into master Aug 5, 2016
@gavofyork gavofyork deleted the spec-arc-engine branch August 5, 2016 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rphmeier @coveralls @gavofyork