Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array size #413

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Array size #413

merged 3 commits into from
Mar 18, 2023

Conversation

burdges
Copy link
Contributor

@burdges burdges commented Mar 18, 2023

I guess you guys ignore Decode::encoded_fixed_size these? There are a lot more of these missing. Also Input does not even have a mechanism for skipping bytes.

bkchr
bkchr approved these changes Mar 18, 2023
View reviewed changes
src/codec.rs Outdated Show resolved Hide resolved
src/codec.rs Outdated Show resolved Hide resolved
src/codec.rs Outdated Show resolved Hide resolved
src/codec.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Mar 18, 2023

I guess you guys ignore Decode::encoded_fixed_size these? There are a lot more of these missing. Also Input does not even have a mechanism for skipping bytes.

Yes there are still a lot missing.

@bkchr
Copy link
Member

bkchr commented Mar 18, 2023

bot merge

@bkchr bkchr merged commit 1ecacab into paritytech:master Mar 18, 2023
@bkchr
Copy link
Member

bkchr commented Mar 18, 2023

🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burdges @bkchr