Improve DB validation tool #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arkpar
commented
Apr 16, 2023
arkpar
commented
- Added an alternative hash column iteration. The index is copied to memory, sorted by disk offset and then iterated. This makes checking large databases 100x faster.
- Also added some code to follow free entry lists and check them for correctness.
cheme
approved these changes
Apr 17, 2023
| let tables = self.tables.read(); | ||
| let index = &tables.index; | ||
|
|
||
| let entries = index.sorted_entries()?; |
There was a problem hiding this comment.
Could probably use start_chunk as a restart parameter, but would still need to rebuild sorted entries at all restart so probably something that only make sense to put in place if really needed at some point.
Tpt
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.