Remove heapsize #94

cheme · 2019-01-14T17:00:57Z

This PR is an alternative to #93 , it skips the deprecation step and directly remove heapsize usage in all parity-common crates.

Like #93 it is a follow up to #89 . It could also be a follow up to #93 if we first deprecate things.

Edit: #93 needs to be merged first because it includes fixes for macos

(it is the less impacting approach).

`get_malloc_size_src.sh`. Add missing impls.rs with ethereum types related implementation.

version too).

Fix a no_std deps issue.

Documentation enhancements. Explicits imports.

of any use).

Co-Authored-By: cheme <[email protected]>

…tools2

switching back to jemalloc.

estimate.

ordian

Could you update https://github.com/paritytech/parity-common/pull/94/files#diff-800310df350583bcaff8649efb9b9042L16 and resolve merge conflicts? Looks good otherwise.

version.

cheme · 2019-01-16T13:16:15Z

I did resolve merge conflict, I am generally more in favor with merging #93 in a first step.
I have seen some ongoing refacto on uint and primitive crate and I fear that proceding with removal before doing the switch in parity-ethereum and substrate (I did not prepare a PR for substrate yet) may possible change on those crates for a bit.

cheme · 2019-01-23T08:12:10Z

I put this pr on ice (behind #93) that fix the mac behavior.

ordian · 2019-05-31T15:12:56Z

@cheme, could you resolve conflicts?

ordian · 2019-05-31T15:13:26Z

removing onice since #93 is merged

util-mem.

keccak-hash/Cargo.toml

Co-Authored-By: Andronik Ordian <[email protected]>

dvdplm

Looks nice in general but as this is probably going to have a huge impact upstream, we need new versions of all dependent crates.
Personally I'd love some guidance/docs in the crate on the recommended way of updating code upstream that currently use the heapsizeof crate (explicitly or implicitly through features).

transaction-pool/Cargo.toml

triehash/Cargo.toml

dvdplm · 2019-05-31T15:39:25Z

parity-util-mem/README.md

@@ -4,7 +4,6 @@ Collection of memory related utilities.

 ## Features

- volatile-erase : Not set by default, `Memzero` struct will be erasing memory through a simple [`write_volatile`](https://doc.rust-lang.org/std/ptr/fn.write_volatile.html) call.
 - estimate-heapsize : Do not use allocator, but `size_of` or `size_of_val`.


(commenting here because GH doesn't allow me to comment below)

Need to update the ## Dependency section too now that CoD is removed.

dvdplm · 2019-05-31T15:41:01Z

parity-util-mem/README.md

@@ -4,7 +4,6 @@ Collection of memory related utilities.

 ## Features


Can you add a recommended way of using this crate to, for example, replace code that uses heapsizeof today and wishes to stop? :)

parity-util-mem/Cargo.toml

kvdb-rocksdb/Cargo.toml

…m_heapsize

dvdplm · 2019-05-31T18:01:25Z

parity-util-mem/Cargo.toml

-parking_lot = { version = "*", optional = true }
+elastic-array = { version = "0", optional = true }
+ethereum-types = { version = "0", optional = true }
+parking_lot = { version = "0", optional = true }


This should work fine, says cargo publish --dry-run

dvdplm · 2019-05-31T19:26:06Z

Published v0.1.0

cheme and others added 30 commits December 6, 2018 19:41

Mem tools by including trait and specific implementation in the crate

25270be

(it is the less impacting approach).

Plug malloc_size_of as a patched copy. Documentation is done by

94bb293

`get_malloc_size_src.sh`. Add missing impls.rs with ethereum types related implementation.

A few additional impl for parity-eth use

197a27d

Removal of heapsize (no proper crate versioning and pending on mem crate

f816aaf

version too).

Allocators.

2a0cc08

heapsize estimation for allocator without use_size fn.

418e03b

Init no_std compat.

6105606

Remove conditianal test code.

59b4d55

Fix a no_std deps issue.

Renaming of mem repo to crate name.

efadc31

Documentation enhancements. Explicits imports.

Remove conditional mettering for now (will need some testing to check if

b2f1708

of any use).

tab

fb127a7

Remove features get form malloc_size and simply delete code instead.

d5aa899

Update parity-util-mem/README.md

fd9dc92

Co-Authored-By: cheme <[email protected]>

Missing windows import

3df427b

Merge branch 'mem-tools2' of github.com:cheme/parity-common into mem-…

da88f97

…tools2

Use self for winapi.

ef9a5b6

Correct import.

1b0b2e3

Merge branch 'master' into rem_heapsize

8839576

Small renaming, test confirm that only memorydb need update before

5fd398f

switching back to jemalloc.

shallow size on Arc with malloc return -1 (max val), replacing with

5340912

estimate.

use cfg_if to makes feature choice more explicit.

8ada814

Plug on github branch (test brokens)

e3516d2

Remove servo specific impls (unused).

61c60b0

estimate_heapsize in travis.

767dc90

Merge branch 'master' into mem-tools2

9876b65

Merge branch 'master' into mem-tools2

a8a9b0e

Remove last serde and remove servo_arc reference.

a31851e

Add missing version

73e8c7e

Use malloc_size_of_derive from crates.

64135ac

Merge branch 'mem-tools2' into rem_heapsize

af24ca4

cheme added the A0-pleasereview label Jan 16, 2019

ordian approved these changes Jan 16, 2019

View reviewed changes

cheme added 2 commits January 16, 2019 14:07

Merge branch 'master' into rem_heapsize, and update uint readme crate

d770316

version.

Merge branch 'master' into rem_heapsize

a0a2577

restore test dependency

ca27409

cheme added the A1-onice label Jan 23, 2019

dvdplm mentioned this pull request May 31, 2019

[parity-util-mem] Update to 2018 Edition and prep for publication #176

Closed

ordian removed the A1-onice label May 31, 2019

Merge branch 'master' into rem_heapsize, remove clear_on_drop from

c6a6982

util-mem.

ordian reviewed May 31, 2019

View reviewed changes

keccak-hash/Cargo.toml Outdated Show resolved Hide resolved

Update keccak-hash/Cargo.toml

b7de962

Co-Authored-By: Andronik Ordian <[email protected]>

dvdplm suggested changes May 31, 2019

View reviewed changes

cheme mentioned this pull request May 31, 2019

Deprecate heapsize paritytech/trie#14

Merged

cheme added 4 commits May 31, 2019 18:20

fix readme comment

a65dcdb

Allow no_std for estimate_size

45860cd

Merge branch 'rem_heapsize' of github.com:cheme/parity-common into re…

ba4dd7c

…m_heapsize

use a version, not sure a major version only is valid for publishing

96c860b

dvdplm reviewed May 31, 2019

View reviewed changes

fix warnings

1b0bc65

dvdplm approved these changes May 31, 2019

View reviewed changes

dvdplm added A8-looksgood and removed A0-pleasereview labels May 31, 2019

cheme added 2 commits May 31, 2019 20:38

fix warnings

0fbc1ce

fix string import warning

18d3f99

dvdplm merged commit 8ebc5c8 into paritytech:master May 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove heapsize #94

Remove heapsize #94

cheme commented Jan 14, 2019 •

edited

Loading

ordian left a comment

cheme commented Jan 16, 2019

cheme commented Jan 23, 2019

ordian commented May 31, 2019

ordian commented May 31, 2019

dvdplm left a comment •

edited

Loading

dvdplm May 31, 2019

dvdplm May 31, 2019

dvdplm May 31, 2019

dvdplm commented May 31, 2019

		@@ -4,7 +4,6 @@ Collection of memory related utilities.

		## Features

Remove heapsize #94

Remove heapsize #94

Conversation

cheme commented Jan 14, 2019 • edited Loading

ordian left a comment

Choose a reason for hiding this comment

cheme commented Jan 16, 2019

cheme commented Jan 23, 2019

ordian commented May 31, 2019

ordian commented May 31, 2019

dvdplm left a comment • edited Loading

Choose a reason for hiding this comment

dvdplm May 31, 2019

Choose a reason for hiding this comment

dvdplm May 31, 2019

Choose a reason for hiding this comment

dvdplm May 31, 2019

Choose a reason for hiding this comment

dvdplm commented May 31, 2019

cheme commented Jan 14, 2019 •

edited

Loading

dvdplm left a comment •

edited

Loading