Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvdb-rocksdb: support the rocksdb/multi-threaded-cf feature #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cchudant
Copy link

The rocksdb crate supports a feature called multi-threaded-cf, which wraps column family descriptors into RwLocks. and change some types around.
Enabling it in a downstream app makes kvdb-rocksdb then fail to compile.

Questions:

  • should I add a compile test to the CI to make sure future changes compile under that rocksdb flag?

@ordian
Copy link
Member

ordian commented Aug 10, 2024

should I add a compile test to the CI to make sure future changes compile under that rocksdb flag?

yes, please

do you think we should also expose this feature in kvdb-rocksdb? as in

[features]
# ...
multi-threaded-cf = ["rocksdb/multi-threaded-cf"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants